Type:
Task
Priority:
Critical
Resolution:
Fixed
The purpose of this task is to ensure that CREATE TRIGGER is atomic
When a trigger is created, we first create a trigger_name.TRN file and then
create or update the table_name.TRG files.
This is done by creating .TRN~ and .TRG~ files and replacing (or creating)
the result files.
The new logic is
Log CREATE TRIGGER to DDL log, with a marker if old trigger existsted
If old .TRN or .TRG files exists, make backup copies of these
Create the new .TRN and .TRG files as before
Remove the backups
Crash recovery
If query has been logged to binary log:
delete any left over backup files
else
Delete any old .TRN~ or .TRG~ files
If there was orignally some triggers (old .TRG file existed)
If we crashed before creating all backup files
Delete existing backup files
else
Restore backup files
end
Delete .TRN and .TRG file (as there was no triggers before
One benefit of the new code is that CREATE OR REPLACE TRIGGER is now
totally atomic even if there existed an old trigger: Either the old
trigger will be replaced or the old one will be left untouched.
{"report":{"fcp":1168.3000001907349,"ttfb":367.30000019073486,"pageVisibility":"visible","entityId":96461,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"c35efead-4bab-497d-8e9b-cb5ecc765d68","navigationType":0,"readyForUser":1242.7000002861023,"redirectCount":0,"resourceLoadedEnd":1389.5,"resourceLoadedStart":372.7000002861023,"resourceTiming":[{"duration":305.7999997138977,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":372.7000002861023,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":372.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":678.5,"responseStart":0,"secureConnectionStart":0},{"duration":305.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":373,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":373,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":678.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":315.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":373.09999990463257,"connectEnd":373.09999990463257,"connectStart":373.09999990463257,"domainLookupEnd":373.09999990463257,"domainLookupStart":373.09999990463257,"fetchStart":373.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":373.09999990463257,"responseEnd":688.5999999046326,"responseStart":688.5,"secureConnectionStart":373.09999990463257},{"duration":381.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":373.30000019073486,"connectEnd":373.30000019073486,"connectStart":373.30000019073486,"domainLookupEnd":373.30000019073486,"domainLookupStart":373.30000019073486,"fetchStart":373.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":373.30000019073486,"responseEnd":754.8000001907349,"responseStart":754.8000001907349,"secureConnectionStart":373.30000019073486},{"duration":385.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":373.5,"connectEnd":373.5,"connectStart":373.5,"domainLookupEnd":373.5,"domainLookupStart":373.5,"fetchStart":373.5,"redirectEnd":0,"redirectStart":0,"requestStart":373.5,"responseEnd":758.9000000953674,"responseStart":758.9000000953674,"secureConnectionStart":373.5},{"duration":385.7999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":373.7000002861023,"connectEnd":373.7000002861023,"connectStart":373.7000002861023,"domainLookupEnd":373.7000002861023,"domainLookupStart":373.7000002861023,"fetchStart":373.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":373.7000002861023,"responseEnd":759.5,"responseStart":759.5,"secureConnectionStart":373.7000002861023},{"duration":386,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":373.90000009536743,"connectEnd":373.90000009536743,"connectStart":373.90000009536743,"domainLookupEnd":373.90000009536743,"domainLookupStart":373.90000009536743,"fetchStart":373.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":373.90000009536743,"responseEnd":759.9000000953674,"responseStart":759.9000000953674,"secureConnectionStart":373.90000009536743},{"duration":460.2000002861023,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":374.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":374.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":834.3000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":386.5,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":374.2000002861023,"connectEnd":374.2000002861023,"connectStart":374.2000002861023,"domainLookupEnd":374.2000002861023,"domainLookupStart":374.2000002861023,"fetchStart":374.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":374.2000002861023,"responseEnd":760.7000002861023,"responseStart":760.7000002861023,"secureConnectionStart":374.2000002861023},{"duration":460,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":374.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":374.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":834.4000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":386.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":374.59999990463257,"connectEnd":374.59999990463257,"connectStart":374.59999990463257,"domainLookupEnd":374.59999990463257,"domainLookupStart":374.59999990463257,"fetchStart":374.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":374.59999990463257,"responseEnd":761.4000000953674,"responseStart":761.4000000953674,"secureConnectionStart":374.59999990463257},{"duration":633.4000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":379.90000009536743,"connectEnd":379.90000009536743,"connectStart":379.90000009536743,"domainLookupEnd":379.90000009536743,"domainLookupStart":379.90000009536743,"fetchStart":379.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":379.90000009536743,"responseEnd":1013.3000001907349,"responseStart":1013.3000001907349,"secureConnectionStart":379.90000009536743},{"duration":1009.5999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":379.90000009536743,"connectEnd":379.90000009536743,"connectStart":379.90000009536743,"domainLookupEnd":379.90000009536743,"domainLookupStart":379.90000009536743,"fetchStart":379.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":379.90000009536743,"responseEnd":1389.5,"responseStart":1389.5,"secureConnectionStart":379.90000009536743},{"duration":146.39999961853027,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":868.7000002861023,"connectEnd":868.7000002861023,"connectStart":868.7000002861023,"domainLookupEnd":868.7000002861023,"domainLookupStart":868.7000002861023,"fetchStart":868.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":868.7000002861023,"responseEnd":1015.0999999046326,"responseStart":1015.0999999046326,"secureConnectionStart":868.7000002861023},{"duration":327.59999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1117.8000001907349,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1117.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1445.4000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":317.7999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1118.8000001907349,"connectEnd":1118.8000001907349,"connectStart":1118.8000001907349,"domainLookupEnd":1118.8000001907349,"domainLookupStart":1118.8000001907349,"fetchStart":1118.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":1118.8000001907349,"responseEnd":1436.5999999046326,"responseStart":1436.5999999046326,"secureConnectionStart":1118.8000001907349},{"duration":324.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":1119.2000002861023,"connectEnd":1119.2000002861023,"connectStart":1119.2000002861023,"domainLookupEnd":1119.2000002861023,"domainLookupStart":1119.2000002861023,"fetchStart":1119.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":1119.2000002861023,"responseEnd":1443.9000000953674,"responseStart":1443.9000000953674,"secureConnectionStart":1119.2000002861023}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":218,"responseStart":367,"responseEnd":373,"domLoading":371,"domInteractive":1407,"domContentLoadedEventStart":1407,"domContentLoadedEventEnd":1445,"domComplete":2560,"loadEventStart":2560,"loadEventEnd":2562,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1391.3000001907349},{"name":"bigPipe.sidebar-id.end","time":1392.3000001907349},{"name":"bigPipe.activity-panel-pipe-id.start","time":1392.4000000953674},{"name":"bigPipe.activity-panel-pipe-id.end","time":1394.9000000953674},{"name":"activityTabFullyLoaded","time":1452.8000001907349}],"measures":[],"correlationId":"8be16dc07e156e","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":95,"dbReadsTimeInMs":10,"dbConnsTimeInMs":19,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}