Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-24626

Remove synchronous write of page0 and flushing file during file creation

Details

    • Bug
    • Status: Closed (View Workflow)
    • Blocker
    • Resolution: Fixed
    • 10.2(EOL), 10.3(EOL), 10.4(EOL), 10.5, 10.6
    • 10.6.1
    • Storage Engine - InnoDB
    • None

    Description

      InnoDB holds dict_sys mutex while doing file i/o operation during creation of table.
      In fil_ibd_create():

              if (ulint zip_size = fil_space_t::zip_size(flags)) {
      		 
                      page_zip_des_t  page_zip;
      		 
                      page_zip_set_size(&page_zip, zip_size);
      		 
                      page_zip.data = page + srv_page_size;
      		 
      #ifdef UNIV_DEBUG
      		 
                      page_zip.m_start = 0;
      		 
      #endif /* UNIV_DEBUG */
      		 
                      page_zip.m_end = 0;
      		 
                      page_zip.m_nonempty = 0;
      		 
                      page_zip.n_blobs = 0;
      		 
       
      		 
                      buf_flush_init_for_writing(NULL, page, &page_zip, false);
      		 
       
      		 
                      *err = os_file_write(IORequestWrite, path, file,
      		 
                                           page_zip.data, 0, zip_size);
      		 
              } else {
      		 
                      buf_flush_init_for_writing(NULL, page, NULL,
      		 
                                                 fil_space_t::full_crc32(flags));
      		 
       
      		 
                      *err = os_file_write(IORequestWrite, path, file,
      		 
                                           page, 0, srv_page_size);
      		 
              }
      		 
       
      		 
              if (!os_file_flush(file)) {
      		 
                      ib::error() << "File flush of tablespace '"
      		 
                              << path << "' failed";
      		 
                      *err = DB_ERROR;
      		 
                      goto err_exit;
      		 
              }

      If we remove the page0 write and flushing the file then InnoDB should handle this scenario during recovery. Right now, InnoDB does the validation of page0 while parsing the FILE redo log records.

      InnoDB should defer these tablespace as uninitialized if it encounters zero-filled page 0
      and recover page0 of these tablespace before recovering any other pages of these tablespace. This is the idea right now. It could change when we're debuggging encrypted and compressed tablespace.

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. MDEV-14481 Execute InnoDB crash recovery in the background

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25646 Atomic DDL: InnoDB: Datafile './test/<tablename>.ibd' is corrupted. Cannot determine the space ID from the first 64 pages

          • Major - Major loss of function.
          • Closed
          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25967 Server restarted on backupped data crashes during CHECK TABLE

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26326 MDEV-24626 (remove synchronous page0 write) seems to cause mariabackup to skip valid ibd file.

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-27817 InnoDB recovery of recently created files is not crash-safe

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-28923 atomic.rename_table occasionally fails

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-28974 mariadb-backup --prepare fails to prepare a backup that involves DDL

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-28977 Race condition in the recovery of CREATE TABLE or table-rebuilding DDL

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-30069 InnoDB: Trying to write ... bytes at ... outside the bounds of the file ...

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31098 InnoDB Recovery doesn't display encryption message when no encryption configuration passed

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25655 Atomic DDL: InnoDB: Cannot replay rename of tablespace, error Data structure corruption

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25665 safe_mutex: Trying to lock mutex ... fil0fil.cc ... when the mutex was already locked log0recv.cc

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25852 Orphan #sql*.ibd files are occasionally left behind after killed ALTER TABLE

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25909 Unnecessary calls to fil_ibd_load() slow down recovery

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26326 MDEV-24626 (remove synchronous page0 write) seems to cause mariabackup to skip valid ibd file.

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26631 Race condition in the test innodb.doublewrite

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-28870 InnoDB: Missing FILE_CREATE, FILE_DELETE or FILE_MODIFY before FILE_CHECKPOINT during crash recovery

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29987 Bogus errors about file size in the test mariabackup.defer_space

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-30132 Crash after recovery, with InnoDB: Tried to read ... bytes at offset

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-32939 If tables are frequently created, renamed, dropped, a backup cannot be restored

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-18200 MariaBackup full backup failed with InnoDB: Failing assertion: success in storage/innobase/fil/fil0fil.cc line 657

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25656 Atomic DDL: Assertion `!full_crc32(flags)' failed in fil_space_t::logical_size(ulint)

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25657 Atomic DDL: InnoDB: Cannot apply log, double free or corruption (fasttop)

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26001 InnoDB: Cannot apply log to [page id: space=152, page number=0] of corrupted file

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Transition Time In Source Status Execution Times
            Thirunarayanan Balathandayuthapani made transition -
            Open In Progress
            		48d 23h 13m 1
            Thirunarayanan Balathandayuthapani made transition -
            In Progress In Review
            		7d 22h 24m 2
            Marko Mäkelä made transition -
            In Review Stalled
            		17d 5h 39m 2
            Thirunarayanan Balathandayuthapani made transition -
            Stalled In Progress
            		9d 17h 33m 2
            Marko Mäkelä made transition -
            In Progress Closed
            		34d 4h 21m 1

            People

              marko Marko Mäkelä
              thiru Thirunarayanan Balathandayuthapani
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.