Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-24623

Galera does not support MDEV-515 bulk insert

Details

    Description

      MDEV-515 will replace row-level locking with table-level locking in the special case that an INSERT is performed into an empty table or partition.

      This causes a few replication testMajors to fail. We have adjusted some tests by inserting an extra record into the table, so that the normal row-level locking and undo logging will be used. But, some tests will require deeper studying to assess whether such a work-around is acceptable or whether some improvements to the replication logic will be needed.

      Attachments

        Issue Links

          is caused by

          Task - A task that needs to be done. MDEV-515 innodb bulk insert

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-30420 Assertion `mode_ == m_local' failed in int wsrep::client_state::append_key(const wsrep::key&)

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            marko Marko Mäkelä created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            julien.fritsch Julien Fritsch made changes -
            Assignee Seppo Jaakola [ seppo ] Jan Lindström [ jplindst ]
            julien.fritsch Julien Fritsch made changes -
            marko Marko Mäkelä added a comment -

            Here is the list of tests that failed for me locally (with non-debug galera-4 library):

            galera.galera_bf_kill
            		 
            galera.galera_ist_mariabackup
            		 
            galera.galera_ist_mariabackup_innodb_flush_logs
            		 
            galera.galera_ist_mysqldump
            		 
            galera.galera_ist_rsync
            		 
            galera.galera_mdev_15611
            		 
            galera.galera_partition
            		 
            galera.galera_pc_recovery
            		 
            galera.galera_sst_mariabackup
            		 
            galera.galera_sst_mariabackup_data_dir
            		 
            galera.galera_sst_mysqldump_with_key
            		 
            galera.galera_sst_rsync
            		 
            galera.galera_sst_rsync2
            		 
            galera.galera_sst_rsync_data_dir
            		 
            galera.galera_var_innodb_disallow_writes
            		 
            galera.MDEV-6860
            		 
            galera.mysql-wsrep#33
            		 
            galera_sr.galera_sr_dupkey_error
            		 
            galera_sr.galera_sr_parallel_apply
            		 
            galera_sr.GCF-1018B
            		 
            galera_sr.GCF-572
            		 
            galera_sr.GCF-623
            		 
            galera_sr.mysql-wsrep-features#32
            		 
            galera_sr.GCF-1008

            I killed the test while it was executing galera_sr.GCF-1008 (I think it was hung).

            marko Marko Mäkelä added a comment - Here is the list of tests that failed for me locally (with non-debug galera-4 library): galera.galera_bf_kill galera.galera_ist_mariabackup galera.galera_ist_mariabackup_innodb_flush_logs galera.galera_ist_mysqldump galera.galera_ist_rsync galera.galera_mdev_15611 galera.galera_partition galera.galera_pc_recovery galera.galera_sst_mariabackup galera.galera_sst_mariabackup_data_dir galera.galera_sst_mysqldump_with_key galera.galera_sst_rsync galera.galera_sst_rsync2 galera.galera_sst_rsync_data_dir galera.galera_var_innodb_disallow_writes galera.MDEV-6860 galera.mysql-wsrep#33 galera_sr.galera_sr_dupkey_error galera_sr.galera_sr_parallel_apply galera_sr.GCF-1018B galera_sr.GCF-572 galera_sr.GCF-623 galera_sr.mysql-wsrep-features#32 galera_sr.GCF-1008 I killed the test while it was executing galera_sr.GCF-1008 (I think it was hung).
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä added a comment -

            seppo suggested that the MDEV-515 optimization be disabled on Galera cluster (!trx->is_wsrep()) until this has been addressed. That will allow MDEV-515 to enter 10.6 without having to wait for Galera to be adjusted.

            marko Marko Mäkelä added a comment - seppo suggested that the MDEV-515 optimization be disabled on Galera cluster ( !trx->is_wsrep() ) until this has been addressed. That will allow MDEV-515 to enter 10.6 without having to wait for Galera to be adjusted.
            marko Marko Mäkelä made changes -
            Labels regression-10.6 performance
            Priority Blocker [ 1 ] Major [ 3 ]
            Summary Galera tests failing after MDEV-515 Galera does not support MDEV-515 bulk insert
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 118243 ] MariaDB v4 [ 142504 ]
            Roel Roel Van de Paar made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            jplindst Jan Lindström (Inactive) made changes -
            Priority Critical [ 2 ] Major [ 3 ]
            seppo Seppo Jaakola made changes -
            Assignee Jan Lindström [ jplindst ] Seppo Jaakola [ seppo ]
            seppo Seppo Jaakola made changes -
            Assignee Seppo Jaakola [ seppo ]
            seppo Seppo Jaakola made changes -
            Assignee Seppo Jaakola [ seppo ]
            seppo Seppo Jaakola made changes -
            Assignee Seppo Jaakola [ seppo ] Denis Protivensky [ JIRAUSER52676 ]
            denis.protivensky Denis Protivensky made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            ramesh Ramesh Sivaraman made changes -
            ramesh Ramesh Sivaraman added a comment -

            jplindst pquery testing looks good in the bug fix branch

            ramesh Ramesh Sivaraman added a comment - jplindst pquery testing looks good in the bug fix branch
            jplindst Jan Lindström (Inactive) made changes -
            Assignee Denis Protivensky [ JIRAUSER52676 ] Jan Lindström [ jplindst ]
            jplindst Jan Lindström (Inactive) made changes -
            issue.field.resolutiondate 2023-01-24 10:31:25.0 2023-01-24 10:31:25.341
            jplindst Jan Lindström (Inactive) made changes -
            Fix Version/s 10.6.12 [ 28513 ]
            Fix Version/s 10.7.8 [ 28515 ]
            Fix Version/s 10.8.7 [ 28517 ]
            Fix Version/s 10.9.5 [ 28519 ]
            Fix Version/s 10.10.3 [ 28521 ]
            Fix Version/s 10.6 [ 24028 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            marko Marko Mäkelä added a comment -

            I hope that this was tested on 10.7 as well, because the logic is somewhat different there due to MDEV-24621.

            marko Marko Mäkelä added a comment - I hope that this was tested on 10.7 as well, because the logic is somewhat different there due to MDEV-24621 .
            ramesh Ramesh Sivaraman added a comment -

            Yes tested on 10.7 as well

            ramesh Ramesh Sivaraman added a comment - Yes tested on 10.7 as well

            People

              jplindst Jan Lindström (Inactive)
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.