[MDEV-24623] Galera does not support MDEV-515 bulk insert Created: 2021-01-19  Updated: 2023-01-25  Resolved: 2023-01-24

Status: Closed
Project: MariaDB Server
Component/s: Galera
Affects Version/s: 10.6
Fix Version/s: 10.6.12, 10.7.8, 10.8.7, 10.9.5, 10.10.3

Type: Bug Priority: Major
Reporter: Marko Mäkelä Assignee: Jan Lindström (Inactive)
Resolution: Fixed Votes: 0
Labels: performance

Issue Links:
Problem/Incident
is caused by MDEV-515 innodb bulk insert Closed
Relates
relates to MDEV-30420 Assertion `mode_ == m_local' failed i... Closed

 Description   

MDEV-515 will replace row-level locking with table-level locking in the special case that an INSERT is performed into an empty table or partition.

This causes a few replication testMajors to fail. We have adjusted some tests by inserting an extra record into the table, so that the normal row-level locking and undo logging will be used. But, some tests will require deeper studying to assess whether such a work-around is acceptable or whether some improvements to the replication logic will be needed.

 Comments   
Comment by Marko Mäkelä [ 2021-01-21 ]

Here is the list of tests that failed for me locally (with non-debug galera-4 library):

galera.galera_bf_kill
 
galera.galera_ist_mariabackup
 
galera.galera_ist_mariabackup_innodb_flush_logs
 
galera.galera_ist_mysqldump
 
galera.galera_ist_rsync
 
galera.galera_mdev_15611
 
galera.galera_partition
 
galera.galera_pc_recovery
 
galera.galera_sst_mariabackup
 
galera.galera_sst_mariabackup_data_dir
 
galera.galera_sst_mysqldump_with_key
 
galera.galera_sst_rsync
 
galera.galera_sst_rsync2
 
galera.galera_sst_rsync_data_dir
 
galera.galera_var_innodb_disallow_writes
 
galera.MDEV-6860
 
galera.mysql-wsrep#33
 
galera_sr.galera_sr_dupkey_error
 
galera_sr.galera_sr_parallel_apply
 
galera_sr.GCF-1018B
 
galera_sr.GCF-572
 
galera_sr.GCF-623
 
galera_sr.mysql-wsrep-features#32
 
galera_sr.GCF-1008

I killed the test while it was executing galera_sr.GCF-1008 (I think it was hung).

Comment by Marko Mäkelä [ 2021-01-22 ]

seppo suggested that the MDEV-515 optimization be disabled on Galera cluster (!trx->is_wsrep()) until this has been addressed. That will allow MDEV-515 to enter 10.6 without having to wait for Galera to be adjusted.

Comment by Ramesh Sivaraman [ 2023-01-24 ]

jplindst pquery testing looks good in the bug fix branch

Comment by Marko Mäkelä [ 2023-01-24 ]

I hope that this was tested on 10.7 as well, because the logic is somewhat different there due to MDEV-24621.

Comment by Ramesh Sivaraman [ 2023-01-25 ]

Yes tested on 10.7 as well

Generated at Thu Feb 08 09:31:24 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.