Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-23875

select into outfile not respect UMASK and UMASK_DIR

Details

    Description

      select into outfile creates files everytime with 666 permission, regardsless if umask environment variables and umask settings on OS level.

      It seems hardcoded.

      /***************************************************************************
      		 
      ** Export of select to textfile
      		 
      ***************************************************************************/
      		 
      [..] 
      static File create_file(THD *thd, char *path, sql_exchange *exchange,
      		 
      			IO_CACHE *cache)
      		 
      [...]
      		 
       /* Create the file world readable */
      		 
        if ((file= mysql_file_create(key_select_to_file,
      		 
                                     path, 0666, O_WRONLY|O_EXCL, MYF(MY_WME))) < 0)
      		 
          return file;
      		 
      #ifdef HAVE_FCHMOD
      		 
        (void) fchmod(file, 0666);			// Because of umask()
      		 
      #else
      		 
       (void) chmod(path, 0666);
      		 
      #endif

      It should use my_umask instead to respect UMASK and UMASK_DIR environment variables.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-15844 Add umask and umask_dir as server variable

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Needs Feedback

          Bug - A problem which impairs or prevents the functions of the product. MDEV-23058 UMASK and UMASK_DIR are modes, not umasks

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            Richard Richard Stracke created issue -
            Richard Richard Stracke made changes -
            Field Original Value New Value
            Richard Richard Stracke made changes -
            elenst Elena Stepanova made changes -
            Component/s Server [ 13907 ]
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.5 [ 23123 ]
            Assignee Sergei Golubchik [ serg ]
            serg Sergei Golubchik made changes -
            Status Open [ 1 ] Confirmed [ 10101 ]
            serg Sergei Golubchik made changes -
            Summary select into outfile not respekt UMASK and UMASK_DIR select into outfile not respect UMASK and UMASK_DIR
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Rucha Deodhar [ rucha174 ]
            julien.fritsch Julien Fritsch made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            rucha174 Rucha Deodhar made changes -
            Status Confirmed [ 10101 ] In Progress [ 3 ]
            rucha174 Rucha Deodhar made changes -
            Assignee Rucha Deodhar [ rucha174 ] Sergei Golubchik [ serg ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Rucha Deodhar [ rucha174 ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            rucha174 Rucha Deodhar made changes -
            Fix Version/s 10.2.37 [ 25112 ]
            Fix Version/s 10.3.28 [ 25111 ]
            Fix Version/s 10.4.18 [ 25110 ]
            Fix Version/s 10.5.9 [ 25109 ]
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 114163 ] MariaDB v4 [ 158428 ]
            mariadb-jira-automation Jira Automation (IT) made changes -
            Zendesk Related Tickets 114123

            People

              rucha174 Rucha Deodhar
              Richard Richard Stracke
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.