Details
Critical Description
select into outfile creates files everytime with 666 permission, regardsless if umask environment variables and umask settings on OS level.
It seems hardcoded.
/***************************************************************************
|
** Export of select to textfile
|
***************************************************************************/
|
[..]
|
static File create_file(THD *thd, char *path, sql_exchange *exchange, |
IO_CACHE *cache)
|
[...]
|
/* Create the file world readable */ |
if ((file= mysql_file_create(key_select_to_file, |
path, 0666, O_WRONLY|O_EXCL, MYF(MY_WME))) < 0) |
return file; |
#ifdef HAVE_FCHMOD
|
(void) fchmod(file, 0666); // Because of umask() |
#else |
(void) chmod(path, 0666); |
#endif
|
It should use my_umask instead to respect UMASK and UMASK_DIR environment variables.
Attachments
Issue Links
- relates to
-
MDEV-15844 Add umask and umask_dir as server variable
-
- Needs Feedback
-
-
MDEV-23058 UMASK and UMASK_DIR are modes, not umasks
-
- Closed
-
Activity
Supposedly the server always used 0666 (at least since MySQL 3.20.13, March 1997) because mysqld is normally running under mysql:mysql, so unless files are 0666 they won't be of much use.
Which is very different from UMASK, that sets the mode for table and frm files — files that should not be readable outside of mysql:mysql
The main issue with the 666 mode is the last digit. Security auditors are quite unhappy with world-writable files. If making this configurable is not an option right now, at least change the mode to 644 - it will still let anybody consume the file while not letting it change it.
So, changing to 0640 makes absolutely no sense to me. Using UMASK makes no sense either.
New umask server variable does, but it really seems an overkill here. One can simply create a new directory and let the server write there.
The small change that I think we, probably, should do still is to change 0666 to 0664
I disagree about UMASK and UMASK_DIR environment variables.
First, these are not masks, but file creation modes, which is quite confusing and bad.
https://jira.mariadb.org/browse/MDEV-23058?focusedCommentId=158790&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-158790
Second, using a MariaDB configuration variable will be much better, because: