[MDEV-23857] replication master password length - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Affects Version/s: 10.2(EOL), 10.3(EOL), 10.4(EOL), 10.5
Fix Version/s: 10.5.26, 10.6.19, 10.11.9, 11.1.6, 11.2.5, 11.4.3
Component/s: Replication
Labels:
- replication

Description

Using "CHANGE MASTER TO" command and setting master password with a length more than 41 ascii chars make replication works (no error or warning returned) but replication failed due to "access denied" when restarting mariadb.
master password is truncated to 41 chars in master.info file so when restarting replication it uses truncated password to connect to master.

Attachments

Activity

Ascending order - Click to sort in descending order

Brandon Nesterenko added a comment - 2021-06-14 23:29

In MySQL, the behavior for this is to error (introduced in 5.7.5). Do we want to follow this same pattern? That is, do we want to follow their same implementation logic from their patch? Elkin

Brandon Nesterenko added a comment - 2021-06-14 23:29 In MySQL, the behavior for this is to error (introduced in 5.7.5 ). Do we want to follow this same pattern? That is, do we want to follow their same implementation logic from their patch ? Elkin

Andrei Elkin added a comment - 2021-06-15 10:53

bnestere: I think yes, their policy is reasonable.

Andrei Elkin added a comment - 2021-06-15 10:53 bnestere : I think yes, their policy is reasonable.

Brandon Nesterenko added a comment - 2021-06-16 23:24

I saw that logic had already been added to ensure that the password length was valid after issuing a CHANGE MASTER command from MDEV-4013 (patch, and which also extended the max password length to 96 ASCII characters). The issue that is present in this bug is strictly related to reading the master.info file, where the code reads a maximum of 41 characters for the password. I have implemented a fix for this to use the size of the password array rather than a separate value.

Patch
Buildbot

Brandon Nesterenko added a comment - 2021-06-16 23:24 I saw that logic had already been added to ensure that the password length was valid after issuing a CHANGE MASTER command from MDEV-4013 ( patch , and which also extended the max password length to 96 ASCII characters). The issue that is present in this bug is strictly related to reading the master.info file, where the code reads a maximum of 41 characters for the password. I have implemented a fix for this to use the size of the password array rather than a separate value. Patch Buildbot

Daniel Black added a comment - 2022-05-26 03:02

Nice and simple patch. Well done.

Daniel Black added a comment - 2022-05-26 03:02 Nice and simple patch. Well done.

Sergei Golubchik added a comment - 2024-06-16 16:11

https://github.com/MariaDB/server/commit/d0809e2dd3c8e5617fb15c0b331aea35c3df3cf1
is ok to push

Sergei Golubchik added a comment - 2024-06-16 16:11 https://github.com/MariaDB/server/commit/d0809e2dd3c8e5617fb15c0b331aea35c3df3cf1 is ok to push

Brandon Nesterenko added a comment - 2024-06-19 11:56

Pushed into 10.5 as 6cab2f75fe2

No merge conflicts seen when manually cherry picking into 11.6.

Brandon Nesterenko added a comment - 2024-06-19 11:56 Pushed into 10.5 as 6cab2f75fe2 No merge conflicts seen when manually cherry picking into 11.6.

People

Assignee:: Brandon Nesterenko

Reporter:: MathNao

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 2020-09-30 11:20

Updated:: 2024-06-19 11:56

Resolved:: 2024-06-19 11:56

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server