[MDEV-23857] replication master password length Created: 2020-09-30 Updated: 2023-12-15 |
|
| Status: | In Review |
| Project: | MariaDB Server |
| Component/s: | Replication |
| Affects Version/s: | 10.2, 10.3, 10.4, 10.5 |
| Fix Version/s: | 10.4, 10.5 |
| Type: | Bug | Priority: | Critical |
| Reporter: | MathNao | Assignee: | Andrei Elkin |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | replication | ||
| Description |
|
Using "CHANGE MASTER TO" command and setting master password with a length more than 41 ascii chars make replication works (no error or warning returned) but replication failed due to "access denied" when restarting mariadb. |
| Comments |
| Comment by Brandon Nesterenko [ 2021-06-14 ] |
|
In MySQL, the behavior for this is to error (introduced in 5.7.5). Do we want to follow this same pattern? That is, do we want to follow their same implementation logic from their patch? Elkin |
| Comment by Andrei Elkin [ 2021-06-15 ] |
|
bnestere: I think yes, their policy is reasonable. |
| Comment by Brandon Nesterenko [ 2021-06-16 ] |
|
I saw that logic had already been added to ensure that the password length was valid after issuing a CHANGE MASTER command from MDEV-4013 (patch, and which also extended the max password length to 96 ASCII characters). The issue that is present in this bug is strictly related to reading the master.info file, where the code reads a maximum of 41 characters for the password. I have implemented a fix for this to use the size of the password array rather than a separate value. |
| Comment by Daniel Black [ 2022-05-26 ] |
|
Nice and simple patch. Well done. |