Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-23287

INET4 data type

Details

    Description

      Under terms of MDEV-274 we added the INET6 data type, to store IPv6 addresses as 16-byte binary strings.

      Let's also add a data type to store IPv4 addresses, as 4-byte binary strings.

      The new data type name will be INET4.

      Under terms of this task, INET4 and INET6 won't support mutual explicit or implicit CAST. That will be done separately when needed.

      But INET4 should be implemented in the same directory with INET6: plugin/type_inet/, so later INET4 and INET6 "know" each other, to implement mutual cast.

      Attachments

        Issue Links

          causes

          Task - A task that needs to be done. MDEV-30146 Change maturity of plugins for January 2023 Releases

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-274 The data type for IPv6/IPv4 addresses in MariaDB

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29920 INET4 data type is not documented

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bar Alexander Barkov added a comment -

            serg, please review a patch in:
            https://github.com/MariaDB/server/tree/bb-10.10-bar-inet4

            bar Alexander Barkov added a comment - serg , please review a patch in: https://github.com/MariaDB/server/tree/bb-10.10-bar-inet4
            serg Sergei Golubchik added a comment -

            commit 1f897b447ec is good, thanks.

            Typo: in a couple of places you say "10.0 tests".

            Do we want inet4->inet6 conversion to work? I think it's what users might expect. But let's have it as a separate task.

            serg Sergei Golubchik added a comment - commit 1f897b447ec is good, thanks. Typo: in a couple of places you say "10.0 tests". Do we want inet4->inet6 conversion to work? I think it's what users might expect. But let's have it as a separate task.
            bar Alexander Barkov added a comment - - edited

            elenst, please find a preview branch preview-10.10-misc for testing. Thanks.

            bar Alexander Barkov added a comment - - edited elenst , please find a preview branch preview-10.10-misc for testing. Thanks.
            serg Sergei Golubchik added a comment -

            The feature is also in bb-10.10-MDEV-23287 without other misc features

            serg Sergei Golubchik added a comment - The feature is also in bb-10.10- MDEV-23287 without other misc features
            bar Alexander Barkov added a comment - - edited

            Please find an updated version in bb-10.10-bar-MDEV-23287-inet4.
            It was rebased to the latest 10.10 and now returns errors when mixing INET4 with non-compatible types at the preparation time (i.e. before iterating rows) rather than at the execution time (during iterating rows). Also, more MTR tests were added.

            bar Alexander Barkov added a comment - - edited Please find an updated version in bb-10.10-bar- MDEV-23287 -inet4. It was rebased to the latest 10.10 and now returns errors when mixing INET4 with non-compatible types at the preparation time (i.e. before iterating rows) rather than at the execution time (during iterating rows). Also, more MTR tests were added.
            alice Alice Sherepa added a comment - - edited

            it is ok to push it into 10.10. Thanks!

            alice Alice Sherepa added a comment - - edited it is ok to push it into 10.10. Thanks!

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              2 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.