[MDEV-23287] INET4 data type Created: 2020-07-25  Updated: 2023-08-07  Resolved: 2022-07-08

Status: Closed
Project: MariaDB Server
Component/s: Data types
Fix Version/s: 10.10.0

Type: Task Priority: Critical
Reporter: Alexander Barkov Assignee: Alexander Barkov
Resolution: Fixed Votes: 2
Labels: Preview_10.10

Issue Links:
Problem/Incident
causes MDEV-30146 Change maturity of plugins for Januar... Closed
Relates
relates to MDEV-274 The data type for IPv6/IPv4 addresses... Closed
relates to MDEV-29920 INET4 data type is not documented Open

 Description   

Under terms of MDEV-274 we added the INET6 data type, to store IPv6 addresses as 16-byte binary strings.

Let's also add a data type to store IPv4 addresses, as 4-byte binary strings.

The new data type name will be INET4.

Under terms of this task, INET4 and INET6 won't support mutual explicit or implicit CAST. That will be done separately when needed.

But INET4 should be implemented in the same directory with INET6: plugin/type_inet/, so later INET4 and INET6 "know" each other, to implement mutual cast.



 Comments   
Comment by Alexander Barkov [ 2022-06-09 ]

serg, please review a patch in:
https://github.com/MariaDB/server/tree/bb-10.10-bar-inet4

Comment by Sergei Golubchik [ 2022-06-13 ]

commit 1f897b447ec is good, thanks.

Typo: in a couple of places you say "10.0 tests".

Do we want inet4->inet6 conversion to work? I think it's what users might expect. But let's have it as a separate task.

Comment by Alexander Barkov [ 2022-06-14 ]

elenst, please find a preview branch preview-10.10-misc for testing. Thanks.

Comment by Sergei Golubchik [ 2022-06-27 ]

The feature is also in bb-10.10-MDEV-23287 without other misc features

Comment by Alexander Barkov [ 2022-06-29 ]

Please find an updated version in bb-10.10-bar-MDEV-23287-inet4.
It was rebased to the latest 10.10 and now returns errors when mixing INET4 with non-compatible types at the preparation time (i.e. before iterating rows) rather than at the execution time (during iterating rows). Also, more MTR tests were added.

Comment by Alice Sherepa [ 2022-07-08 ]

it is ok to push it into 10.10. Thanks!

Generated at Thu Feb 08 09:21:16 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.