Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-23070

Duplicated counting of MONITOR_ADAPTIVE_HASH_ROW_ADDED

    XMLWordPrintable

Details

    Description

      MDEV-22871 not only added some missing MONITOR_INC(MONITOR_ADAPTIVE_HASH_ROW_ADDED) statements, but also added a redundant one in btr_search_build_page_hash_index(). After the loop, we are adding n_cached to the count:

      diff --git a/storage/innobase/btr/btr0sea.cc b/storage/innobase/btr/btr0sea.cc
      		 
      index de2f58a23b4..92cb38d0a85 100644
      		 
      --- a/storage/innobase/btr/btr0sea.cc
      		 
      +++ b/storage/innobase/btr/btr0sea.cc
      		 
      @@ -1656,7 +1656,6 @@ btr_search_build_page_hash_index(
      		 
       		for (ulint i = 0; i < n_cached; i++) {
      		 
       			ha_insert_for_fold(&part->table, part->heap,
      		 
       					   folds[i], block, recs[i]);
      		 
      -			MONITOR_INC(MONITOR_ADAPTIVE_HASH_ROW_ADDED);
      		 
       		}
      		 
       	}

      This bug was fixed in a merge to 10.5.

      Attachments

        Issue Links

          is caused by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-22871 Contention on the buf_pool.page_hash

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Activity

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.