[MDEV-23070] Duplicated counting of MONITOR_ADAPTIVE_HASH_ROW_ADDED Created: 2020-07-02  Updated: 2020-07-02  Resolved: 2020-07-02

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - InnoDB
Affects Version/s: 10.5.4
Fix Version/s: 10.5.5

Type: Bug Priority: Major
Reporter: Marko Mäkelä Assignee: Marko Mäkelä
Resolution: Fixed Votes: 0
Labels: regression-10.5

Issue Links:
Blocks
Problem/Incident
is caused by MDEV-22871 Contention on the buf_pool.page_hash Closed

 Description   

MDEV-22871 not only added some missing MONITOR_INC(MONITOR_ADAPTIVE_HASH_ROW_ADDED) statements, but also added a redundant one in btr_search_build_page_hash_index(). After the loop, we are adding n_cached to the count:

diff --git a/storage/innobase/btr/btr0sea.cc b/storage/innobase/btr/btr0sea.cc
index de2f58a23b4..92cb38d0a85 100644
--- a/storage/innobase/btr/btr0sea.cc
+++ b/storage/innobase/btr/btr0sea.cc
@@ -1656,7 +1656,6 @@ btr_search_build_page_hash_index(
 		for (ulint i = 0; i < n_cached; i++) {
 			ha_insert_for_fold(&part->table, part->heap,
 					   folds[i], block, recs[i]);
-			MONITOR_INC(MONITOR_ADAPTIVE_HASH_ROW_ADDED);
 		}
 	}
 

This bug was fixed in a merge to 10.5.


Generated at Thu Feb 08 09:19:37 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.