Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-22989

Make cmake error out when unsupported option is passed as CMAKE_BUILD_TYPE

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Open (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Fix Version/s: 10.6
    • Component/s: Compiling
    • Labels:
      None

      Description

      A mistake that seems to be quite common, which I currently experienced whilst investigating a `DBUG_SYNC` test failure reported by Michael Widenius, is that it is actually possible to pass ` -DCMAKE_BUILD_TYPE=mysql_release` to cmake, even though `mysql_release` is a `BUILD_CONFIG` not a `BUILD_TYPE`.
      In this case the build continues just fine, but all sorts of undefined things happen with the server code because odd combinations of `#define` happen when they shouldn't.

      We should make cmake fail if an unsupported option is passed as `BUILD_TYPE`.

        Attachments

          Activity

            People

            Assignee:
            robertbindar Robert Bindar
            Reporter:
            robertbindar Robert Bindar
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated: