Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-22399

Remove multiple calls to enable and disable Handler::keyread and perform it after the plan refinement phase is done

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • None
    • 10.5.4
    • Optimizer
    • None

    Description

      Monty mentioned

      Find a solution for test_if_skip_sort_order() and key_reads. The problem is that we set key_read for indexes early and then test_if_skip_sort_order() have to delete old ones and in some cases add new ones. It would be better if the optimizer didn't enable key reads until after all indexes have been decided and can't be changed anymore.

      So the idea is to let all the plan refinements happen and all then enable the keyread for indexes.

      Attachments

        Activity

          varun Varun Gupta (Inactive) added a comment - First attempt of the patch was https://github.com/MariaDB/server/commit/744a4fce6a10bf6f1f06190941bbd10d4f9149bc
          varun Varun Gupta (Inactive) added a comment - Patch after addressing review https://github.com/mariadb/server/commit/cb1a2bb1281e7d469be0c7c4dea64078267b041a#diff-1

          ok to push as long as all valgrind and MSAN builds are ok

          monty Michael Widenius added a comment - ok to push as long as all valgrind and MSAN builds are ok

          People

            varun Varun Gupta (Inactive)
            varun Varun Gupta (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.