Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-22354

stop "mariabackup --prepare" on errors during inndb redo log applying

Details

    Description

      --prepare does not stop at the first "Not applying INSERT_REUSE_DYNAMIC"? It kept applying log records after that. Check if it is affecting 10.5 only, the code was heavily refactored in MDEV-12353, but a similar bug could be possible in older versions.

      Attachments

        Activity

          marko Marko Mäkelä added a comment -

          vlad.lesin, I think that this is fixed.

          I just noticed that the fix was pushed to the 10.2 branch using the wrong MDEV number 22554 instead of this one:

          commit 0f9bfcc323f76389eab23220d757e1cdfacb0543
          		 
          Author: Vlad Lesin …
          		 
          Date:   Wed May 13 14:32:12 2020 +0300
          		 
           
          		 
              MDEV-22554: "mariabackup --prepare" exits with code 0 even though innodb
          		 
              error is logged
          		 
              
              The fix is to set flag in ib::error::~error() and check it in
          		 
              mariabackup.
          		 
              
              ib::error::error() is replaced with ib::warn::warn() in
          		 
              AIO::linux_create_io_ctx() because of two reasons:
          		 
              
              1) if we leave it as is, then mariabackup MTR tests will fail with --mem
          		 
              option, because Linux AIO can not be used on tmpfs,
          		 
              
              2) when Linux AIO can not be initialized, InnoDB falls back to simulated
          		 
              AIO, so such sutiation is not fatal error, it should be treated as warning.

          marko Marko Mäkelä added a comment - vlad.lesin , I think that this is fixed. I just noticed that the fix was pushed to the 10.2 branch using the wrong MDEV number 22554 instead of this one: commit 0f9bfcc323f76389eab23220d757e1cdfacb0543 Author: Vlad Lesin … Date: Wed May 13 14:32:12 2020 +0300   MDEV-22554: "mariabackup --prepare" exits with code 0 even though innodb error is logged The fix is to set flag in ib::error::~error() and check it in mariabackup. ib::error::error() is replaced with ib::warn::warn() in AIO::linux_create_io_ctx() because of two reasons: 1) if we leave it as is, then mariabackup MTR tests will fail with --mem option, because Linux AIO can not be used on tmpfs, 2) when Linux AIO can not be initialized, InnoDB falls back to simulated AIO, so such sutiation is not fatal error, it should be treated as warning.

          People

            vlad.lesin Vladislav Lesin
            vlad.lesin Vladislav Lesin
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.