[MDEV-22354] stop "mariabackup --prepare" on errors during inndb redo log applying Created: 2020-04-23  Updated: 2020-08-10  Resolved: 2020-08-10

Status: Closed
Project: MariaDB Server
Component/s: mariabackup
Affects Version/s: 10.5
Fix Version/s: 10.5.4, 10.2.33, 10.3.24, 10.4.14

Type: Bug Priority: Major
Reporter: Vladislav Lesin Assignee: Vladislav Lesin
Resolution: Fixed Votes: 0
Labels: None


 Description   

--prepare does not stop at the first "Not applying INSERT_REUSE_DYNAMIC"? It kept applying log records after that. Check if it is affecting 10.5 only, the code was heavily refactored in MDEV-12353, but a similar bug could be possible in older versions.



 Comments   
Comment by Marko Mäkelä [ 2020-08-10 ]

vlad.lesin, I think that this is fixed.

I just noticed that the fix was pushed to the 10.2 branch using the wrong MDEV number 22554 instead of this one:

commit 0f9bfcc323f76389eab23220d757e1cdfacb0543
Author: Vlad Lesin …
Date:   Wed May 13 14:32:12 2020 +0300
 
    MDEV-22554: "mariabackup --prepare" exits with code 0 even though innodb
    error is logged
    
    The fix is to set flag in ib::error::~error() and check it in
    mariabackup.
    
    ib::error::error() is replaced with ib::warn::warn() in
    AIO::linux_create_io_ctx() because of two reasons:
    
    1) if we leave it as is, then mariabackup MTR tests will fail with --mem
    option, because Linux AIO can not be used on tmpfs,
    
    2) when Linux AIO can not be initialized, InnoDB falls back to simulated
    AIO, so such sutiation is not fatal error, it should be treated as warning.

Generated at Thu Feb 08 09:14:06 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.