Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-22243

type_test.type_test_double fails with 'NUMERIC_SCALE NULL'

Details

    Description

      Noticed in http://buildbot.askmonty.org/buildbot/builders/kvm-deb-bionic-amd64/builds/4415/steps/mtr/logs/stdio:

      type_test.type_test_double               w4 [ fail ]
              Test ended at 2020-04-14 08:20:04
       
      CURRENT_TEST: type_test.type_test_double
      --- /usr/share/mysql/mysql-test/plugin/type_test/type_test/type_test_double.result	2020-04-14 05:32:13.000000000 -0400
      +++ /dev/shm/var/4/log/type_test_double.reject	2020-04-14 08:20:04.455194071 -0400
      @@ -290,7 +290,7 @@
       CHARACTER_MAXIMUM_LENGTH	NULL
       CHARACTER_OCTET_LENGTH	NULL
       NUMERIC_PRECISION	22
      -NUMERIC_SCALE	31
      +NUMERIC_SCALE	NULL
       DATETIME_PRECISION	NULL
       CHARACTER_SET_NAME	NULL
       COLLATION_NAME	NULL
       
      mysqltest: Result length mismatch
      

      On current 10.5 master this test is not at all visible (e.g. http://buildbot.askmonty.org/buildbot/builders/kvm-deb-bionic-amd64/builds/4413/steps/mtr/logs/stdio) because Debian packaging was omitting usr/lib/mysql/plugin/type_test.so and this test did simply not run before.

      Attachments

        Activity

          otto, so shall https://github.com/MariaDB/server/pull/1506 be merged and this MDEV closed?

          serg Sergei Golubchik added a comment - otto , so shall https://github.com/MariaDB/server/pull/1506 be merged and this MDEV closed?

          PR https://github.com/MariaDB/server/pull/1506 was merged yesterday, thus going into version 11.3.0.

          otto Otto Kekäläinen added a comment - PR https://github.com/MariaDB/server/pull/1506 was merged yesterday, thus going into version 11.3.0.

          After re-enabling the test if still fails with the exact same error on all tested architectures at https://launchpad.net/~otto/+archive/ubuntu/mariadb/+builds?build_text=&build_state=all

          otto Otto Kekäläinen added a comment - After re-enabling the test if still fails with the exact same error on all tested architectures at https://launchpad.net/~otto/+archive/ubuntu/mariadb/+builds?build_text=&build_state=all

          There where several reasons why the test failed:

          • Constructors for Field_double and Field_float changed an argument
            to the constructor instead of a the correct class variable.
          • gcc 7.5.0 produced wrong code when inlining Field_double constructor
            into Field_test_double constructor.

          Fixed by changing the correct class variable and make the constructors
          not inline to go around the gcc bug.

          monty Michael Widenius added a comment - There where several reasons why the test failed: Constructors for Field_double and Field_float changed an argument to the constructor instead of a the correct class variable. gcc 7.5.0 produced wrong code when inlining Field_double constructor into Field_test_double constructor. Fixed by changing the correct class variable and make the constructors not inline to go around the gcc bug.

          I confirm https://github.com/MariaDB/server/commit/9d19b6526917c94ca03ef1b4c57152882b192cfe fixed this test failure - it is no longer visible on any of my test builds on Launchpad.

          otto Otto Kekäläinen added a comment - I confirm https://github.com/MariaDB/server/commit/9d19b6526917c94ca03ef1b4c57152882b192cfe fixed this test failure - it is no longer visible on any of my test builds on Launchpad.

          People

            monty Michael Widenius
            otto Otto Kekäläinen
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.