Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-21949

key rotation for innodb_encrypt_log is not working in 10.5

Details

    Description

      Found by reading the code. https://github.com/MariaDB/server/blob/17080cbcf04ab295806db8aaaeead2696988fab4/storage/innobase/log/log0crypt.cc#L158

      So, all key rotation logic depends on log_t::FORMAT_ENC_10_4 while in 10.5 it should also work for log_t::FORMAT_ENC_10_5

      Attachments

        Issue Links

          is caused by

          Task - A task that needs to be done. MDEV-12353 Efficient InnoDB redo log record format

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-12041 Implement key rotation for innodb_encrypt_log

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            kevg Eugene Kosov (Inactive) created issue -
            kevg Eugene Kosov (Inactive) made changes -
            Field Original Value New Value
            Assignee Eugene Kosov [ kevg ]
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä added a comment -

            The fix will change the format of the redo log record blocks when using innodb_encrypt_log.

            Because the log format was changed (and this bug introduced) in MariaDB 10.5.2 by MDEV-12353 and related changes, it would be best if also this fix were included in MariaDB 10.5.2. If we fail to include this fix in 10.5.2, then we would have to implement another redo log format tag for the 10.5.3+ encrypted redo log and maybe also implement upgrade logic from 10.5.2 to later 10.5 versions.

            marko Marko Mäkelä added a comment - The fix will change the format of the redo log record blocks when using innodb_encrypt_log . Because the log format was changed (and this bug introduced) in MariaDB 10.5.2 by MDEV-12353 and related changes, it would be best if also this fix were included in MariaDB 10.5.2. If we fail to include this fix in 10.5.2, then we would have to implement another redo log format tag for the 10.5.3+ encrypted redo log and maybe also implement upgrade logic from 10.5.2 to later 10.5 versions.
            marko Marko Mäkelä made changes -
            Priority Major [ 3 ] Blocker [ 1 ]
            marko Marko Mäkelä made changes -
            Fix Version/s 10.5.2 [ 24030 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 104875 ] MariaDB v4 [ 157439 ]

            People

              kevg Eugene Kosov (Inactive)
              kevg Eugene Kosov (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.