[MDEV-21949] key rotation for innodb_encrypt_log is not working in 10.5 Created: 2020-03-16  Updated: 2020-03-16  Resolved: 2020-03-16

Status: Closed
Project: MariaDB Server
Component/s: Encryption, Storage Engine - InnoDB
Affects Version/s: 10.5
Fix Version/s: 10.5.2

Type: Bug Priority: Blocker
Reporter: Eugene Kosov (Inactive) Assignee: Eugene Kosov (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Problem/Incident
is caused by MDEV-12353 Efficient InnoDB redo log record format Closed
Relates
relates to MDEV-12041 Implement key rotation for innodb_enc... Closed

 Description   

Found by reading the code. https://github.com/MariaDB/server/blob/17080cbcf04ab295806db8aaaeead2696988fab4/storage/innobase/log/log0crypt.cc#L158

So, all key rotation logic depends on log_t::FORMAT_ENC_10_4 while in 10.5 it should also work for log_t::FORMAT_ENC_10_5

 Comments   
Comment by Marko Mäkelä [ 2020-03-16 ]

The fix will change the format of the redo log record blocks when using innodb_encrypt_log.

Because the log format was changed (and this bug introduced) in MariaDB 10.5.2 by MDEV-12353 and related changes, it would be best if also this fix were included in MariaDB 10.5.2. If we fail to include this fix in 10.5.2, then we would have to implement another redo log format tag for the 10.5.3+ encrypted redo log and maybe also implement upgrade logic from 10.5.2 to later 10.5 versions.

Generated at Thu Feb 08 09:11:03 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.