Details
-
Task
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
None
Description
1. Generally, we accept all-zeroes page checksums because of this code: https://github.com/MariaDB/server/blob/b30446c85dbf0fd402a7833e1042bc13be7fece2/storage/innobase/page/page0zip.cc#L4877 So, lets state it in the code
2. All-zeroes pages are correct for page_zip_verify_checksum()
3. reinterpret_cast<uint64_t*> from char* is incorrect (UB). It needs to be fixed.
Note that since 10.4.3 https://jira.mariadb.org/browse/MDEV-12026 InnoDB can compute CRC32 checksum without bitwise XOR. And such checksum can be 0 only when all input is zeroes.
Attachments
Issue Links
- relates to
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Link |
This issue relates to |
| Fix Version/s | 10.1.45 [ 23913 ] | |
| Fix Version/s | 10.2 [ 14601 ] | |
| Fix Version/s | 10.1 [ 16100 ] | |
| Fix Version/s | 10.3 [ 22126 ] | |
| Fix Version/s | 10.4 [ 22408 ] | |
| Fix Version/s | 10.5 [ 23123 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | Open [ 1 ] | Closed [ 6 ] |
| Fix Version/s | 10.2.32 [ 24221 ] | |
| Fix Version/s | 10.3.23 [ 24222 ] | |
| Fix Version/s | 10.4.13 [ 24223 ] |
| Fix Version/s | 10.5.3 [ 24263 ] |
| Fix Version/s | 10.5.2 [ 24030 ] | |
| Fix Version/s | 10.5.3 [ 24263 ] |
| Workflow | MariaDB v3 [ 104778 ] | MariaDB v4 [ 134202 ] |