Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-21839

Handle crazy offset to SHOW BINLOG EVENTS

Details

    Description

      SHOW BINLOG EVENTS FROM <"random"-pos> caused a variety of failures as reported in MDEV-18046. They are fixed but that approach is not future-proof as well as is not optimal to create extra check for being constructed
      event parameters.
      The extra checks can and should be avoided with conduction validation
      to the supplied offset. The validation means scan of the requested log
      to find the requested position as one that points to the beginning of an event. Scanning is meaningful only to a non-default binlog-checksum-off files (that fact is captured by MDEV-18046).

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-32628 Cryptic ERROR message & inconsistent behavior on incorrect SHOW BINLOG EVENTS FROM ...

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            sujatha.sivakumar Sujatha Sivakumar (Inactive) added a comment -

            Hello Andrei,

            Can you please review the fix for MDEV-21839.

            Patch: https://github.com/MariaDB/server/commit/5bcf3104c94bfeeff2f9376b4d2065046b0e14de

            Build Bot Testing: http://buildbot.askmonty.org/buildbot/grid?category=main&branch=bb-10.1-sujatha

            Didn't add new tests as existing tests do the necessary testing:

            binlog.binlog_show_binlog_event_random_pos
            binlog.binlog_invalid_read_in_rotate

            sujatha.sivakumar Sujatha Sivakumar (Inactive) added a comment - Hello Andrei, Can you please review the fix for MDEV-21839 . Patch: https://github.com/MariaDB/server/commit/5bcf3104c94bfeeff2f9376b4d2065046b0e14de Build Bot Testing: http://buildbot.askmonty.org/buildbot/grid?category=main&branch=bb-10.1-sujatha Didn't add new tests as existing tests do the necessary testing: binlog.binlog_show_binlog_event_random_pos binlog.binlog_invalid_read_in_rotate
            sujatha.sivakumar Sujatha Sivakumar (Inactive) added a comment -

            Hello Monty,

            Can you please review the fix for MDEV-21839.

            Patch: https://github.com/MariaDB/server/commit/61e34736742dab7401810a218c0f5d193409eea9
            BuildBot Link: http://buildbot.askmonty.org/buildbot/grid?category=main&branch=bb-10.1-sujatha

            Thank you.

            sujatha.sivakumar Sujatha Sivakumar (Inactive) added a comment - Hello Monty, Can you please review the fix for MDEV-21839 . Patch: https://github.com/MariaDB/server/commit/61e34736742dab7401810a218c0f5d193409eea9 BuildBot Link: http://buildbot.askmonty.org/buildbot/grid?category=main&branch=bb-10.1-sujatha Thank you.
            sujatha.sivakumar Sujatha Sivakumar (Inactive) added a comment -

            Patch approved by Andrei, on git hub.

            sujatha.sivakumar Sujatha Sivakumar (Inactive) added a comment - Patch approved by Andrei, on git hub.
            sujatha.sivakumar Sujatha Sivakumar (Inactive) added a comment -

            Fix is pushed in 10.1.47.

            10.2:
            ====
            No merge conflicts. But following file changes are not required from 10.2 and higer versions.
            Hence reverted it.

            /mysql-test/r/ctype_cp932_binlog_stm.result

            10.2: https://github.com/MariaDB/server/commit/af28b96e3d005d8d0cb99985ce61a78a7778aa20

            10.3:
            ====
            Clean merge from 10.2 to 10.3.

            10.3: https://github.com/MariaDB/server/commit/edf45efe33f2aeaa01ff45eaeec832f841c0ace0

            10.4:
            ====
            https://github.com/MariaDB/server/commit/14ab041de76c8f74de222b21bc9951282bfe8898

            10.5:
            =====
            https://github.com/MariaDB/server/commit/475de254a8591d5d8006570d914469e359de60cc

            sujatha.sivakumar Sujatha Sivakumar (Inactive) added a comment - Fix is pushed in 10.1.47. 10.2: ==== No merge conflicts. But following file changes are not required from 10.2 and higer versions. Hence reverted it. /mysql-test/r/ctype_cp932_binlog_stm.result 10.2: https://github.com/MariaDB/server/commit/af28b96e3d005d8d0cb99985ce61a78a7778aa20 10.3: ==== Clean merge from 10.2 to 10.3. 10.3: https://github.com/MariaDB/server/commit/edf45efe33f2aeaa01ff45eaeec832f841c0ace0 10.4: ==== https://github.com/MariaDB/server/commit/14ab041de76c8f74de222b21bc9951282bfe8898 10.5: ===== https://github.com/MariaDB/server/commit/475de254a8591d5d8006570d914469e359de60cc

            People

              sujatha.sivakumar Sujatha Sivakumar (Inactive)
              Elkin Andrei Elkin
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.