Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.0(EOL), 10.1(EOL), 10.2(EOL), 10.3(EOL), 10.4(EOL), 10.5
Description
MySQL 5.7.29 includes a fix for avoiding some crashes in IndexPurge::next() in ALTER TABLE…IMPORT TABLESPACE:
Bug#29454828 ASSERTION ON IMPORT VIA TRANSPORTABLE TABLESPACE
The test case introduces some fault injection that does not appear to cover the changed functionality.
MariaDB should fix this in a better way, by replacing the btr_pcur_move_to_next_user_rec() call with equivalent code, and replacing the btr_pcur_move_to_next_page() call with code that will not kill the server, but return an error to the caller.
Ultimately, in MDEV-13542 we should make btr_pcur_move_to_next_user_rec() robust, and check the status in all callers.
Attachments
Issue Links
- blocks
-
-
- Closed
-
-
-
- Closed
-
- relates to
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Link |
This issue blocks |
| Link |
This issue blocks |
| Link |
This issue relates to |
| Description |
MySQL 5.7.29 includes some fixes for making the error handling in {{ALTER TABLE…IMPORT TABLESPACE}} more robust. We should implement the applicable parts in MariaDB Server:
[Bug#29454828 ASSERTION ON IMPORT VIA TRANSPORTABLE TABLESPACE|https://github.com/mysql/mysql-server/commit/48de4d74f4d2f10cd01b129753c7dfa908cf36b5] (and [follow-up fix|https://github.com/mysql/mysql-server/commit/9a8fef9efd071ad44582afef28e7fa6cd492c5ea]) This is improving the error handling for corrupted pages during {{ALTER TABLE…IMPORT TABLESPACE}}. We should fix this in a better way, by passing an inline function parameter rather than by expanding the {{btr_pcur_t}} data structure. [Bug#30190199 - ERROR WHEN IMPORTING TABLESPACE WITH DIFFERENT DATA DIRECTORY LACKS DETAILS|https://github.com/mysql/mysql-server/commit/bd24fc67e68483831d6e16641ae67556006f0cab] MariaDB should probably just ignore any mismatch of a {{DATA DIRECTORY}} clause when importing files. The {{FSP_FLAGS}} in the first page of a {{.ibd}} file indicate whether a {{DATA DIRECTORY}} clause was specified, but that flag is already being mostly ignored by MariaDB. |
MySQL 5.7.29 includes a fix for avoiding some crashes in {{IndexPurge::next()}} in {{ALTER TABLE…IMPORT TABLESPACE}}:
[Bug#29454828 ASSERTION ON IMPORT VIA TRANSPORTABLE TABLESPACE|https://github.com/mysql/mysql-server/commit/48de4d74f4d2f10cd01b129753c7dfa908cf36b5] The test case introduces some fault injection that does not appear to cover the changed functionality. MariaDB should fix this in a better way, by replacing the {{btr_pcur_move_to_next_user_rec()}} call with equivalent code, and replacing the {{btr_pcur_move_to_next_page()}} call with code that will not kill the server, but return an error to the caller. Ultimately, in |
| Labels | corruption upstream-fixed | corruption |
| issue.field.resolutiondate | 2020-01-17 14:38:52.0 | 2020-01-17 14:38:52.195 |
| Fix Version/s | 10.2.31 [ 24017 ] | |
| Fix Version/s | 10.3.22 [ 24018 ] | |
| Fix Version/s | 10.4.12 [ 24019 ] | |
| Fix Version/s | 10.5.1 [ 24029 ] | |
| Fix Version/s | 10.2 [ 14601 ] | |
| Fix Version/s | 10.3 [ 22126 ] | |
| Fix Version/s | 10.4 [ 22408 ] | |
| Fix Version/s | 10.5 [ 23123 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | Open [ 1 ] | Closed [ 6 ] |
| Workflow | MariaDB v3 [ 103125 ] | MariaDB v4 [ 157213 ] |