Details
-
Task
-
Status: Closed (View Workflow)
-
Minor
-
Resolution: Fixed
Description
This task is similar to CONC-449, but this task is for the server itself, and not for MariaDB Connector/C.
Currently, if the $MYSQL_HOME environment variable is set, then MariaDB reads the $MYSQL_HOME/my.cnf configuration file, if it exists:
https://github.com/MariaDB/server/blob/mariadb-10.4.11/mysys/my_default.c#L1206
To further MariaDB's branding, I think MariaDB should similarly check $MARIADB_HOME/my.cnf, if the $MARIADB_HOME environment variable is set.
UPDATE:
The approach should be to only use MARIADB_HOME if set. MYSQL_HOME should only be used if MARIADB_HOME is not set. See also the similar change CONC-537
Attachments
Issue Links
- relates to
-
-
- Closed
-
-
CONC-537 Only read from MYSQL_HOME if MARIADB_HOME is not set
-
- Closed
-
-
-
- Closed
-
Activity
| Description |
Currently, if the {{$MYSQL_HOME}} environment variable is set, then MariaDB reads the {{$MYSQL_HOME/my.cnf}} configuration file, if it exists:
https://github.com/MariaDB/server/blob/mariadb-10.4.11/mysys/my_default.c#L1206 https://mariadb.com/kb/en/library/configuring-mariadb-with-option-files/#default-option-file-locations-on-linux-unix-mac To further MariaDB's branding, I think we should similarly check {{$MARIADB_HOME//my.cnf}}, if the {{$MARIADB_HOME}} environment variable is set. |
This task is similar to Currently, if the {{$MYSQL_HOME}} environment variable is set, then MariaDB reads the {{$MYSQL_HOME/my.cnf}} configuration file, if it exists: https://github.com/MariaDB/server/blob/mariadb-10.4.11/mysys/my_default.c#L1206 https://mariadb.com/kb/en/library/configuring-mariadb-with-option-files/#default-option-file-locations-on-linux-unix-mac To further MariaDB's branding, I think MariaDB should similarly check {{$MARIADB_HOME/my.cnf}}, if the {{$MARIADB_HOME}} environment variable is set. |
| Fix Version/s | 10.5 [ 23123 ] | |
| Assignee | Ralf Gebhardt [ ralf.gebhardt@mariadb.com ] | Rasmus Johansson [ ratzpo ] |
| Link |
This issue relates to |
| Labels | maria |
| Labels | maria |
| Fixing Priority | 250 |
| Epic/Theme | MariaDB Branding |
| Epic/Theme | Branding MariaDB | MariaDB_Branding |
| Fix Version/s | 10.6 [ 24028 ] | |
| Fix Version/s | 10.5 [ 23123 ] |
| Labels | beginner-friendly |
| Assignee | Rasmus Johansson [ ratzpo ] | Rucha Deodhar [ rucha174 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Assignee | Rucha Deodhar [ rucha174 ] | Sergei Golubchik [ serg ] |
| Status | In Progress [ 3 ] | In Review [ 10002 ] |
| Assignee | Sergei Golubchik [ serg ] | |
| Status | In Review [ 10002 ] | Stalled [ 10000 ] |
| Priority | Major [ 3 ] | Minor [ 4 ] |
| Assignee | Geoff Montee [ geoffmontee ] |
| Assignee | Geoff Montee [ geoffmontee ] | Ralf Gebhardt [ ralf.gebhardt@mariadb.com ] |
| Fix Version/s | 10.7 [ 24805 ] | |
| Fix Version/s | 10.6 [ 24028 ] |
| Assignee | Ralf Gebhardt [ ralf.gebhardt@mariadb.com ] |
| Description |
This task is similar to Currently, if the {{$MYSQL_HOME}} environment variable is set, then MariaDB reads the {{$MYSQL_HOME/my.cnf}} configuration file, if it exists: https://github.com/MariaDB/server/blob/mariadb-10.4.11/mysys/my_default.c#L1206 https://mariadb.com/kb/en/library/configuring-mariadb-with-option-files/#default-option-file-locations-on-linux-unix-mac To further MariaDB's branding, I think MariaDB should similarly check {{$MARIADB_HOME/my.cnf}}, if the {{$MARIADB_HOME}} environment variable is set. |
This task is similar to Currently, if the {{$MYSQL_HOME}} environment variable is set, then MariaDB reads the {{$MYSQL_HOME/my.cnf}} configuration file, if it exists: https://github.com/MariaDB/server/blob/mariadb-10.4.11/mysys/my_default.c#L1206 https://mariadb.com/kb/en/library/configuring-mariadb-with-option-files/#default-option-file-locations-on-linux-unix-mac To further MariaDB's branding, I think MariaDB should similarly check {{$MARIADB_HOME/my.cnf}}, if the {{$MARIADB_HOME}} environment variable is set. UPDATE: The approach should be to only use MARIADB_HOME if set. MYSQL_HOME should only be used if MARIADB_HOME is not set |
| Assignee | Rucha Deodhar [ rucha174 ] |
| Status | Stalled [ 10000 ] | In Review [ 10002 ] |
| Assignee | Rucha Deodhar [ rucha174 ] | Sergei Golubchik [ serg ] |
| Assignee | Sergei Golubchik [ serg ] | Rucha Deodhar [ rucha174 ] |
| Status | In Review [ 10002 ] | Stalled [ 10000 ] |
| Description |
This task is similar to Currently, if the {{$MYSQL_HOME}} environment variable is set, then MariaDB reads the {{$MYSQL_HOME/my.cnf}} configuration file, if it exists: https://github.com/MariaDB/server/blob/mariadb-10.4.11/mysys/my_default.c#L1206 https://mariadb.com/kb/en/library/configuring-mariadb-with-option-files/#default-option-file-locations-on-linux-unix-mac To further MariaDB's branding, I think MariaDB should similarly check {{$MARIADB_HOME/my.cnf}}, if the {{$MARIADB_HOME}} environment variable is set. UPDATE: The approach should be to only use MARIADB_HOME if set. MYSQL_HOME should only be used if MARIADB_HOME is not set |
This task is similar to Currently, if the {{$MYSQL_HOME}} environment variable is set, then MariaDB reads the {{$MYSQL_HOME/my.cnf}} configuration file, if it exists: https://github.com/MariaDB/server/blob/mariadb-10.4.11/mysys/my_default.c#L1206 https://mariadb.com/kb/en/library/configuring-mariadb-with-option-files/#default-option-file-locations-on-linux-unix-mac To further MariaDB's branding, I think MariaDB should similarly check {{$MARIADB_HOME/my.cnf}}, if the {{$MARIADB_HOME}} environment variable is set. UPDATE: The approach should be to only use MARIADB_HOME if set. MYSQL_HOME should only be used if MARIADB_HOME is not set. See also the similar change |
| Fix Version/s | 10.6.0 [ 24431 ] | |
| Fix Version/s | 10.7 [ 24805 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | Stalled [ 10000 ] | Closed [ 6 ] |
| Workflow | MariaDB v3 [ 102600 ] | MariaDB v4 [ 134159 ] |
| Issue Type | Task [ 3 ] | Bug [ 1 ] |
| Issue Type | Bug [ 1 ] | Task [ 3 ] |