[MDEV-21365] Check $MARIADB_HOME/my.cnf in addition to $MYSQL_HOME/my.cnf Created: 2019-12-20 Updated: 2021-04-15 Resolved: 2021-03-22 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Configuration |
| Fix Version/s: | 10.6.0 |
| Type: | Task | Priority: | Minor |
| Reporter: | Geoff Montee (Inactive) | Assignee: | Rucha Deodhar |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | beginner-friendly | ||
| Issue Links: |
|
||||||||||||||||
| Description |
|
This task is similar to Currently, if the $MYSQL_HOME environment variable is set, then MariaDB reads the $MYSQL_HOME/my.cnf configuration file, if it exists: https://github.com/MariaDB/server/blob/mariadb-10.4.11/mysys/my_default.c#L1206 To further MariaDB's branding, I think MariaDB should similarly check $MARIADB_HOME/my.cnf, if the $MARIADB_HOME environment variable is set. UPDATE: The approach should be to only use MARIADB_HOME if set. MYSQL_HOME should only be used if MARIADB_HOME is not set. See also the similar change |
| Comments |
| Comment by Geoff Montee (Inactive) [ 2020-01-29 ] |
|
If we want this behavior to be consistent with MariaDB Connector/C, then $MARIADB_HOME should be checked after $MYSQL_HOME. See here: |
| Comment by Sergei Golubchik [ 2021-03-17 ] |
|
I don't think the server should check both $MARIADB_HOME and $MYSQL_HOME. There can be only one home. I'd rather say it should check $MARIADB_HOME first, and only consider $MYSQL_HOME if the former is unset. |
| Comment by Rucha Deodhar [ 2021-03-22 ] |
|
New patch: https://github.com/MariaDB/server/commit/269328884e58e83e7dd7876f90f37e4414ecdee3 |