Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-21365

Check $MARIADB_HOME/my.cnf in addition to $MYSQL_HOME/my.cnf

Details

    Description

      This task is similar to CONC-449, but this task is for the server itself, and not for MariaDB Connector/C.

      Currently, if the $MYSQL_HOME environment variable is set, then MariaDB reads the $MYSQL_HOME/my.cnf configuration file, if it exists:

      https://github.com/MariaDB/server/blob/mariadb-10.4.11/mysys/my_default.c#L1206

      https://mariadb.com/kb/en/library/configuring-mariadb-with-option-files/#default-option-file-locations-on-linux-unix-mac

      To further MariaDB's branding, I think MariaDB should similarly check $MARIADB_HOME/my.cnf, if the $MARIADB_HOME environment variable is set.

      UPDATE:

      The approach should be to only use MARIADB_HOME if set. MYSQL_HOME should only be used if MARIADB_HOME is not set. See also the similar change CONC-537

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. CONC-449 Check $MARIADB_HOME/my.cnf in addition to $MYSQL_HOME/my.cnf

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. CONC-537 Only read from MYSQL_HOME if MARIADB_HOME is not set

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21375 Get option group suffix from $MARIADB_GROUP_SUFFIX in addition to $MYSQL_GROUP_SUFFIX

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            GeoffMontee Geoff Montee (Inactive) added a comment -

            If we want this behavior to be consistent with MariaDB Connector/C, then $MARIADB_HOME should be checked after $MYSQL_HOME. See here:

            https://github.com/mariadb-corporation/mariadb-connector-c/commit/d24e742e0e90f186381be411f0eee6d0baf2363c

            GeoffMontee Geoff Montee (Inactive) added a comment - If we want this behavior to be consistent with MariaDB Connector/C, then $MARIADB_HOME should be checked after $MYSQL_HOME . See here: https://github.com/mariadb-corporation/mariadb-connector-c/commit/d24e742e0e90f186381be411f0eee6d0baf2363c
            serg Sergei Golubchik added a comment -

            I don't think the server should check both $MARIADB_HOME and $MYSQL_HOME. There can be only one home. I'd rather say it should check $MARIADB_HOME first, and only consider $MYSQL_HOME if the former is unset.

            serg Sergei Golubchik added a comment - I don't think the server should check both $MARIADB_HOME and $MYSQL_HOME. There can be only one home. I'd rather say it should check $MARIADB_HOME first, and only consider $MYSQL_HOME if the former is unset.
            rucha174 Rucha Deodhar added a comment -

            New patch: https://github.com/MariaDB/server/commit/269328884e58e83e7dd7876f90f37e4414ecdee3

            rucha174 Rucha Deodhar added a comment - New patch: https://github.com/MariaDB/server/commit/269328884e58e83e7dd7876f90f37e4414ecdee3

            People

              rucha174 Rucha Deodhar
              GeoffMontee Geoff Montee (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.