Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-21365

Check $MARIADB_HOME/my.cnf in addition to $MYSQL_HOME/my.cnf

Details

    Description

      This task is similar to CONC-449, but this task is for the server itself, and not for MariaDB Connector/C.

      Currently, if the $MYSQL_HOME environment variable is set, then MariaDB reads the $MYSQL_HOME/my.cnf configuration file, if it exists:

      https://github.com/MariaDB/server/blob/mariadb-10.4.11/mysys/my_default.c#L1206

      https://mariadb.com/kb/en/library/configuring-mariadb-with-option-files/#default-option-file-locations-on-linux-unix-mac

      To further MariaDB's branding, I think MariaDB should similarly check $MARIADB_HOME/my.cnf, if the $MARIADB_HOME environment variable is set.

      UPDATE:

      The approach should be to only use MARIADB_HOME if set. MYSQL_HOME should only be used if MARIADB_HOME is not set. See also the similar change CONC-537

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. CONC-449 Check $MARIADB_HOME/my.cnf in addition to $MYSQL_HOME/my.cnf

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. CONC-537 Only read from MYSQL_HOME if MARIADB_HOME is not set

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21375 Get option group suffix from $MARIADB_GROUP_SUFFIX in addition to $MYSQL_GROUP_SUFFIX

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            GeoffMontee Geoff Montee (Inactive) created issue -
            GeoffMontee Geoff Montee (Inactive) made changes -
            Field Original Value New Value
            GeoffMontee Geoff Montee (Inactive) made changes -
            Description Currently, if the {{$MYSQL_HOME}} environment variable is set, then MariaDB reads the {{$MYSQL_HOME/my.cnf}} configuration file, if it exists:

            https://github.com/MariaDB/server/blob/mariadb-10.4.11/mysys/my_default.c#L1206

            https://mariadb.com/kb/en/library/configuring-mariadb-with-option-files/#default-option-file-locations-on-linux-unix-mac

            To further MariaDB's branding, I think we should similarly check {{$MARIADB_HOME//my.cnf}}, if the {{$MARIADB_HOME}} environment variable is set.             		This task is similar to CONC-449, but this task is for the server itself, and not for MariaDB Connector/C.

            Currently, if the {{$MYSQL_HOME}} environment variable is set, then MariaDB reads the {{$MYSQL_HOME/my.cnf}} configuration file, if it exists:

            https://github.com/MariaDB/server/blob/mariadb-10.4.11/mysys/my_default.c#L1206

            https://mariadb.com/kb/en/library/configuring-mariadb-with-option-files/#default-option-file-locations-on-linux-unix-mac

            To further MariaDB's branding, I think MariaDB should similarly check {{$MARIADB_HOME/my.cnf}}, if the {{$MARIADB_HOME}} environment variable is set.
            ralf.gebhardt Ralf Gebhardt made changes -
            Fix Version/s 10.5 [ 23123 ]
            Assignee Ralf Gebhardt [ ralf.gebhardt@mariadb.com ] Rasmus Johansson [ ratzpo ]
            GeoffMontee Geoff Montee (Inactive) made changes -
            ralf.gebhardt Ralf Gebhardt made changes -
            Labels maria
            ralf.gebhardt Ralf Gebhardt made changes -
            Labels maria
            julien.fritsch Julien Fritsch made changes -
            Fixing Priority 250
            GeoffMontee Geoff Montee (Inactive) added a comment -

            If we want this behavior to be consistent with MariaDB Connector/C, then $MARIADB_HOME should be checked after $MYSQL_HOME. See here:

            https://github.com/mariadb-corporation/mariadb-connector-c/commit/d24e742e0e90f186381be411f0eee6d0baf2363c

            GeoffMontee Geoff Montee (Inactive) added a comment - If we want this behavior to be consistent with MariaDB Connector/C, then $MARIADB_HOME should be checked after $MYSQL_HOME . See here: https://github.com/mariadb-corporation/mariadb-connector-c/commit/d24e742e0e90f186381be411f0eee6d0baf2363c
            ralf.gebhardt Ralf Gebhardt made changes -
            Epic/Theme MariaDB Branding
            ralf.gebhardt Ralf Gebhardt made changes -
            Epic/Theme Branding MariaDB MariaDB_Branding
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.5 [ 23123 ]
            serg Sergei Golubchik made changes -
            Labels beginner-friendly
            sanja Oleksandr Byelkin made changes -
            Assignee Rasmus Johansson [ ratzpo ] Rucha Deodhar [ rucha174 ]
            rucha174 Rucha Deodhar made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            rucha174 Rucha Deodhar made changes -
            Assignee Rucha Deodhar [ rucha174 ] Sergei Golubchik [ serg ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            serg Sergei Golubchik added a comment -

            I don't think the server should check both $MARIADB_HOME and $MYSQL_HOME. There can be only one home. I'd rather say it should check $MARIADB_HOME first, and only consider $MYSQL_HOME if the former is unset.

            serg Sergei Golubchik added a comment - I don't think the server should check both $MARIADB_HOME and $MYSQL_HOME. There can be only one home. I'd rather say it should check $MARIADB_HOME first, and only consider $MYSQL_HOME if the former is unset.
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            serg Sergei Golubchik made changes -
            Priority Major [ 3 ] Minor [ 4 ]
            serg Sergei Golubchik made changes -
            Assignee Geoff Montee [ geoffmontee ]
            GeoffMontee Geoff Montee (Inactive) made changes -
            Assignee Geoff Montee [ geoffmontee ] Ralf Gebhardt [ ralf.gebhardt@mariadb.com ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Fix Version/s 10.7 [ 24805 ]
            Fix Version/s 10.6 [ 24028 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Assignee Ralf Gebhardt [ ralf.gebhardt@mariadb.com ]
            ralf.gebhardt Ralf Gebhardt made changes -
            ralf.gebhardt Ralf Gebhardt made changes -
            Description This task is similar to CONC-449, but this task is for the server itself, and not for MariaDB Connector/C.

            Currently, if the {{$MYSQL_HOME}} environment variable is set, then MariaDB reads the {{$MYSQL_HOME/my.cnf}} configuration file, if it exists:

            https://github.com/MariaDB/server/blob/mariadb-10.4.11/mysys/my_default.c#L1206

            https://mariadb.com/kb/en/library/configuring-mariadb-with-option-files/#default-option-file-locations-on-linux-unix-mac

            To further MariaDB's branding, I think MariaDB should similarly check {{$MARIADB_HOME/my.cnf}}, if the {{$MARIADB_HOME}} environment variable is set.             		This task is similar to CONC-449, but this task is for the server itself, and not for MariaDB Connector/C.

            Currently, if the {{$MYSQL_HOME}} environment variable is set, then MariaDB reads the {{$MYSQL_HOME/my.cnf}} configuration file, if it exists:

            https://github.com/MariaDB/server/blob/mariadb-10.4.11/mysys/my_default.c#L1206

            https://mariadb.com/kb/en/library/configuring-mariadb-with-option-files/#default-option-file-locations-on-linux-unix-mac

            To further MariaDB's branding, I think MariaDB should similarly check {{$MARIADB_HOME/my.cnf}}, if the {{$MARIADB_HOME}} environment variable is set.

            UPDATE:

            The approach should be to only use MARIADB_HOME if set. MYSQL_HOME should only be used if MARIADB_HOME is not set
            ralf.gebhardt Ralf Gebhardt made changes -
            Assignee Rucha Deodhar [ rucha174 ]
            rucha174 Rucha Deodhar added a comment -

            New patch: https://github.com/MariaDB/server/commit/269328884e58e83e7dd7876f90f37e4414ecdee3

            rucha174 Rucha Deodhar added a comment - New patch: https://github.com/MariaDB/server/commit/269328884e58e83e7dd7876f90f37e4414ecdee3
            rucha174 Rucha Deodhar made changes -
            Status Stalled [ 10000 ] In Review [ 10002 ]
            rucha174 Rucha Deodhar made changes -
            Assignee Rucha Deodhar [ rucha174 ] Sergei Golubchik [ serg ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Rucha Deodhar [ rucha174 ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Description This task is similar to CONC-449, but this task is for the server itself, and not for MariaDB Connector/C.

            Currently, if the {{$MYSQL_HOME}} environment variable is set, then MariaDB reads the {{$MYSQL_HOME/my.cnf}} configuration file, if it exists:

            https://github.com/MariaDB/server/blob/mariadb-10.4.11/mysys/my_default.c#L1206

            https://mariadb.com/kb/en/library/configuring-mariadb-with-option-files/#default-option-file-locations-on-linux-unix-mac

            To further MariaDB's branding, I think MariaDB should similarly check {{$MARIADB_HOME/my.cnf}}, if the {{$MARIADB_HOME}} environment variable is set.

            UPDATE:

            The approach should be to only use MARIADB_HOME if set. MYSQL_HOME should only be used if MARIADB_HOME is not set             		This task is similar to CONC-449, but this task is for the server itself, and not for MariaDB Connector/C.

            Currently, if the {{$MYSQL_HOME}} environment variable is set, then MariaDB reads the {{$MYSQL_HOME/my.cnf}} configuration file, if it exists:

            https://github.com/MariaDB/server/blob/mariadb-10.4.11/mysys/my_default.c#L1206

            https://mariadb.com/kb/en/library/configuring-mariadb-with-option-files/#default-option-file-locations-on-linux-unix-mac

            To further MariaDB's branding, I think MariaDB should similarly check {{$MARIADB_HOME/my.cnf}}, if the {{$MARIADB_HOME}} environment variable is set.

            UPDATE:

            The approach should be to only use MARIADB_HOME if set. MYSQL_HOME should only be used if MARIADB_HOME is not set. See also the similar change CONC-537
            rucha174 Rucha Deodhar made changes -
            Fix Version/s 10.6.0 [ 24431 ]
            Fix Version/s 10.7 [ 24805 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 102600 ] MariaDB v4 [ 134159 ]
            svoj Sergey Vojtovich made changes -
            Issue Type Task [ 3 ] Bug [ 1 ]
            svoj Sergey Vojtovich made changes -
            Issue Type Bug [ 1 ] Task [ 3 ]

            People

              rucha174 Rucha Deodhar
              GeoffMontee Geoff Montee (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.