Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-21363

RPM's postin script only starts and enables systemd service if migrated-from-my.cnf-settings.conf does not already exist

    XMLWordPrintable

    Details

      Description

      The postin script used by our RPM packages only starts and enables the systemd service if migrated-from-my.cnf-settings.conf does not exist. See this block of code:

      if [ -f /usr/lib/systemd/system/mariadb.service -a -x /usr/bin/systemctl ]; then
        systemd_conf=/etc/systemd/system/mariadb.service.d/migrated-from-my.cnf-settings.conf
        if [ -x %{_bindir}/mariadb-service-convert -a ! -f "${systemd_conf}" ]; then
          # Either fresh install or upgrade non-systemd -> systemd
          mkdir -p /etc/systemd/system/mariadb.service.d
          %{_bindir}/mariadb-service-convert > "${systemd_conf}"
          # Make sure old possibly non-systemd instance is down
          if [ $1 = 2 ]; then
            SYSTEMCTL_SKIP_REDIRECT=1 %{_sysconfdir}/init.d/mysql stop >/dev/null 2>&1 || :
            systemctl start mariadb >/dev/null 2>&1 || :
          fi
          systemctl enable mariadb.service >/dev/null 2>&1 || :
        fi
      fi
      

      https://github.com/MariaDB/server/blob/mariadb-10.1.43/support-files/rpm/server-postin.sh#L1

      I don't think systemctl start mariadb and systemctl enable mariadb should be dependent on whether migrated-from-my.cnf-settings.conf exists or not. I think these commands should be executed on all systemd systems during installations.

        Attachments

          Activity

            People

            Assignee:
            sanja Oleksandr Byelkin
            Reporter:
            GeoffMontee Geoff Montee
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated: