[MDEV-20604] Duplicate key value is silently truncated to 64 characters in print_keydup_error - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Affects Version/s: 10.2.27, 10.3.18, 10.4.8
Fix Version/s: 10.2.32, 10.3.23, 10.4.13
Component/s: OTHER
Labels:
- beginner-friendly

Description

When a duplicate key is encountered, the error message is constructed in print_keydup_error:

https://github.com/MariaDB/server/blob/mariadb-10.2.27/sql/handler.cc#L3450

The duplicate value is silently truncated to 64 characters. This is because the format string for the error message sets the field width to 64:

https://github.com/MariaDB/server/blob/mariadb-10.2.27/sql/share/errmsg-utf8.txt#L6166

Truncation is probably fine, but since this specific error involves a "duplicate key", it can be a bit confusing if the user searches the table for that string, and then doesn't find another row with that specific value.

If we can't print the whole value, then the error message may want to mention that the string may be truncated to 64 characters.

Attachments

Issue Links

causes

MDEV-22147 main.mysqldump fails with wrong result (truncated output)

Closed

MDEV-22545 my_vsnprintf behaves not as in C standard

Closed

relates to

MDEV-20605 Awaken transaction can miss inserted by other transaction records due to wrong persistent cursor restoration

Closed

MDEV-20628 If temporary error occurs with optimistic mode of parallel replication, error message has false information

Closed

Activity

Ascending order - Click to sort in descending order

Geoff Montee (Inactive) created issue - 2019-09-16 22:10

Geoff Montee (Inactive) made changes - 2019-09-16 23:31

Field	Original Value	New Value
Link		This issue relates to ~~MDEV-20605~~ [ ~~MDEV-20605~~ ]

Sergei Golubchik made changes - 2019-09-17 17:32

Priority

Major [ 3 ]

Minor [ 4 ]

Sergei Golubchik added a comment - 2019-09-17 17:42

We can fix my_vsprintf to print (optionally) some truncation hint, like "..." if the value was truncated. E.g. "%-.64...s" meaning it'll print "..."

Or we can rephrase the error message to be something like "Duplicate value for the key %$2-.128s: '%$1s'" — this way it'll allow few hundreds bytes for the key value, up to the max error message length of (iirc) 512. But might have compatibility implications if some tool looks for the exact error message text (that no sane tool should do).

Sergei Golubchik added a comment - 2019-09-17 17:42 We can fix my_vsprintf to print (optionally) some truncation hint, like "..." if the value was truncated. E.g. "%-.64...s" meaning it'll print "..." Or we can rephrase the error message to be something like "Duplicate value for the key %$2-.128s: '%$1s'" — this way it'll allow few hundreds bytes for the key value, up to the max error message length of (iirc) 512. But might have compatibility implications if some tool looks for the exact error message text (that no sane tool should do).

Sergei Golubchik made changes - 2019-09-17 17:42

Assignee

Sergei Golubchik [ serg ]

Sergei Golubchik made changes - 2019-09-17 17:42

Labels

beginner-friendly

Geoff Montee (Inactive) made changes - 2019-09-19 00:12

Link

This issue relates to ~~MDEV-20628~~ [ ~~MDEV-20628~~ ]

Julien Fritsch made changes - 2020-01-06 09:02

Priority

Minor [ 4 ]

Major [ 3 ]

Sergei Golubchik made changes - 2020-01-16 17:10

Assignee

Oleksandr Byelkin [ sanja ]

Julien Fritsch made changes - 2020-01-20 13:42

Priority

Major [ 3 ]

Critical [ 2 ]

Oleksandr Byelkin made changes - 2020-02-25 09:20

Status

Open [ 1 ]

In Progress [ 3 ]

Oleksandr Byelkin added a comment - 2020-02-25 09:29

I found that we have plugin for my_snprintf, so theoretically it can be done with a plugin

Oleksandr Byelkin added a comment - 2020-02-25 09:29 I found that we have plugin for my_snprintf, so theoretically it can be done with a plugin

Oleksandr Byelkin made changes - 2020-03-16 11:01

Status

In Progress [ 3 ]

Stalled [ 10000 ]

Oleksandr Byelkin made changes - 2020-03-16 11:01

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Oleksandr Byelkin added a comment - 2020-03-16 11:37

ho big description and no so small test suite:

create table t1 (a varchar(100), UNIQUE KEY akey (a));

insert into t1 values ("1234567890123456789012345678901234567890123456789012345678901234567890_end");

--error ER_DUP_ENTRY

insert into t1 values ("1234567890123456789012345678901234567890123456789012345678901234567890_end");

drop table t1;

Oleksandr Byelkin added a comment - 2020-03-16 11:37 ho big description and no so small test suite: create table t1 (a varchar(100), UNIQUE KEY akey (a)); insert into t1 values ("1234567890123456789012345678901234567890123456789012345678901234567890_end"); --error ER_DUP_ENTRY insert into t1 values ("1234567890123456789012345678901234567890123456789012345678901234567890_end"); drop table t1;

Oleksandr Byelkin added a comment - 2020-03-16 11:39

IMHO we need something shorter than "..." (triple dot), I propose ":".

Oleksandr Byelkin added a comment - 2020-03-16 11:39 IMHO we need something shorter than "..." (triple dot), I propose ":".

Oleksandr Byelkin added a comment - 2020-03-16 16:33

commit 42b77dd0549c8883a497e2385bf6c992222ecb02 (HEAD ~~> bb-10.2MDEV-20604~~, origin/bb-10.2-~~MDEV-20604~~)
Author: Oleksandr Byelkin <sanja@mariadb.com>
Date: Mon Mar 16 16:53:10 2020 +0100

~~MDEV-20604~~: Duplicate key value is silently truncated to 64 characters in print_keydup_error

Added indication of truncated string with special width/precission suffix ':'.

Oleksandr Byelkin added a comment - 2020-03-16 16:33 commit 42b77dd0549c8883a497e2385bf6c992222ecb02 (HEAD > bb-10.2 MDEV-20604 , origin/bb-10.2- MDEV-20604 ) Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Mon Mar 16 16:53:10 2020 +0100 MDEV-20604 : Duplicate key value is silently truncated to 64 characters in print_keydup_error Added indication of truncated string with special width/precission suffix ':'.

Oleksandr Byelkin made changes - 2020-03-20 07:32

Comment

[ commit 11363b44d58ababaef89524d3caca368d04e589a (HEAD -> bb-10.2-release, origin/bb-10.2-release)
Author: Oleksandr Byelkin <sanja@mariadb.com>
Date: Mon Mar 16 16:53:10 2020 +0100

    ~~MDEV-20604~~: Duplicate key value is silently truncated to 64 characters in print_keydup_error

    Added indication of truncated string with special width/precission suffix ':'.

]

Oleksandr Byelkin added a comment - 2020-03-20 07:35

commit 17449c44a5443934909ff38c547e5e6db06b9660 (HEAD -> bb-10.2-release)
Author: Oleksandr Byelkin <sanja@mariadb.com>
Date: Mon Mar 16 16:53:10 2020 +0100

~~MDEV-20604~~: Duplicate key value is silently truncated to 64 characters in print_keydup_error

Added indication of truncated string for "s" format

Oleksandr Byelkin added a comment - 2020-03-20 07:35 commit 17449c44a5443934909ff38c547e5e6db06b9660 (HEAD -> bb-10.2-release) Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Mon Mar 16 16:53:10 2020 +0100 MDEV-20604 : Duplicate key value is silently truncated to 64 characters in print_keydup_error Added indication of truncated string for "s" format

Oleksandr Byelkin made changes - 2020-03-20 07:35

Assignee	Oleksandr Byelkin [ sanja ]	Sergei Golubchik [ serg ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Oleksandr Byelkin made changes - 2020-03-23 11:31

Assignee

Sergei Golubchik [ serg ]

Oleksandr Byelkin [ sanja ]

Oleksandr Byelkin made changes - 2020-03-23 11:31

Status

In Review [ 10002 ]

Stalled [ 10000 ]

Oleksandr Byelkin made changes - 2020-03-23 11:31

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Oleksandr Byelkin made changes - 2020-03-24 09:36

Assignee	Oleksandr Byelkin [ sanja ]	Sergei Golubchik [ serg ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Oleksandr Byelkin added a comment - 2020-03-24 09:38

commit fc90a39426c1756c204b5b3ff2f580a2f4224571 (HEAD ~~> bb-10.2MDEV-20604~~, origin/bb-10.2-release, origin/bb-10.2-~~MDEV-20604~~, bb-10.2-release)
Author: Oleksandr Byelkin <sanja@mariadb.com>
Date: Mon Mar 16 16:53:10 2020 +0100

~~MDEV-20604~~: Duplicate key value is silently truncated to 64 characters in print_keydup_error

Added indication of truncated string for "s" and "M" formats

Oleksandr Byelkin added a comment - 2020-03-24 09:38 commit fc90a39426c1756c204b5b3ff2f580a2f4224571 (HEAD > bb-10.2 MDEV-20604 , origin/bb-10.2-release, origin/bb-10.2- MDEV-20604 , bb-10.2-release) Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Mon Mar 16 16:53:10 2020 +0100 MDEV-20604 : Duplicate key value is silently truncated to 64 characters in print_keydup_error Added indication of truncated string for "s" and "M" formats

Sergei Golubchik made changes - 2020-03-25 17:18

Assignee	Sergei Golubchik [ serg ]	Oleksandr Byelkin [ sanja ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Oleksandr Byelkin made changes - 2020-04-01 09:38

Component/s		OTHER [ 10125 ]
Fix Version/s		10.2.32 [ 24221 ]
Fix Version/s		10.3.23 [ 24222 ]
Fix Version/s		10.4.13 [ 24223 ]
Fix Version/s	10.2 [ 14601 ]
Fix Version/s	10.3 [ 22126 ]
Fix Version/s	10.4 [ 22408 ]
Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

Marko Mäkelä made changes - 2020-05-19 13:52

Link

This issue causes ~~MDEV-22545~~ [ ~~MDEV-22545~~ ]

Marko Mäkelä made changes - 2020-05-19 14:01

Link

This issue causes ~~MDEV-22147~~ [ ~~MDEV-22147~~ ]

Rob Schwyzer (Inactive) made changes - 2021-06-25 17:35

Labels

beginner-friendly

ServiceNow beginner-friendly

Rob Schwyzer (Inactive) made changes - 2021-07-02 19:55

Labels

ServiceNow beginner-friendly

76qDvLB8Gju6Hs7nk3VY3EX42G795W5z beginner-friendly

Sergei Golubchik made changes - 2021-08-13 22:33

Labels

76qDvLB8Gju6Hs7nk3VY3EX42G795W5z beginner-friendly

beginner-friendly

Sergei Golubchik made changes - 2021-12-06 21:50

Workflow

MariaDB v3 [ 99692 ]

MariaDB v4 [ 156753 ]

Jira Automation (IT) made changes - 2024-07-04 03:32

Zendesk Related Tickets		201658 136328
Zendesk active tickets		201658

People

Assignee:: Oleksandr Byelkin

Reporter:: Geoff Montee (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 2019-09-16 22:10

Updated:: 2024-09-06 10:00

Resolved:: 2020-04-01 09:38

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration