Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-20322

rocksdb doesn't free memory on shutdown

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Duplicate
    • 10.2(EOL), 10.3(EOL), 10.4(EOL), 10.5
    • N/A
    • Storage Engine - RocksDB
    • None
    • BUILD/compile-pentium64-valgrind-max

    Description

      When running tests with valgrind, one gets a lot of warnings about not freed memory.
      The solution by Facebook is to add suppression, but that is likely to hide bugs and doesn't work with all memory checking tools, so we should not use this approach but instead try to fix this properly by freeing all memory at plugin unload or at least during shutdown.

      I am adding temporary valgrind suppression for all the issues in 10.5 until this is fixed to be able to run valgrind on the full test suite.

      Example:

      mtr --valgrind mariabackup.xb_rocksdb

      Attachments

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. MDEV-12445 Rocksdb does not shutdown worker threads and aborts in memleak check on server shutdown

          • Major - Major loss of function.
          • Open
          is part of

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20310 valgrind bugs found in 10.5

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20315 MyRocks tests produce valgrind failures

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            monty Michael Widenius added a comment -

            Until this is fixed, we are going to use valgrind suppressions to hide the issue in 10.5 (so that we can run valgrind in buildbot)

            monty Michael Widenius added a comment - Until this is fixed, we are going to use valgrind suppressions to hide the issue in 10.5 (so that we can run valgrind in buildbot)
            marko Marko Mäkelä added a comment -

            As part of fixing the leaks, also the my_disable_leak_check work-around should be removed.

            marko Marko Mäkelä added a comment - As part of fixing the leaks, also the my_disable_leak_check work-around should be removed.
            marko Marko Mäkelä added a comment -

            This report seems to duplicate MDEV-12445.

            marko Marko Mäkelä added a comment - This report seems to duplicate MDEV-12445 .

            People

              psergei Sergei Petrunia
              monty Michael Widenius
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.