Type:
Task
Priority:
Major
Resolution:
Fixed
This is a cleanup task to simplify future development of SQL function and operator overloading.
The only user visible side affect will be the change in error reporting in some cases, e.g.:
-ERROR 21000: Operand should contain 1 column(s)
+ERROR HY000: Illegal parameter data types row and int for operation '+'
To implement easier overloading for SQL operators and functions for user defined data type arguments, we should:
Gradually turn all Item_func descendants (for which we want overloading) into Item_handled_func
Add infrastructure to search and choose best overload candidates. Overload candidates will be searched and chosen during fix_length_and_dec() time.
The default implementation of Item_func::check_arguments(), which disallows ROW type arguments, should be removed for all Item_func_xxx classes that we want overloading for.
As a first step, let's cleanup Item_num_op and Item_func_min_max. Namely, let's do the following:
1. Move Type_handler_row into its own Type_collection_row (separate from Type_collection_std, which after this change will hold only scalar built-in types).
2. Overload Item_num_op::check_arguments() and Item_func_min_max::check_arguments() from the default implementation to:
bool check_arguments() const
{
return false ;
}
Arguments for these classes are checked during aggregate_for_num_op() and aggregate_for_min_max(), which after change #1, will return an error for a combination of ROW and scalar arguments, e.g.:
SELECT ROW(1,1)+2;
SELECT 2+ROW(1,1);
SELECT LEAST(ROW(1,1), 2);
SELECT LEAST(2, ROW(1,1));
and for two ROW arguments:
SELECT ROW(1,1)+ROW(2,2);
SELECT LEAST(ROW(1,1),ROW(2,2));
so the second test for ROW type arguments in check_arguments() won't be needed.
As an additional benefit:
The virtual method Type_handler::is_traditional_type() will be removed
A non-virtual method Type_handller::is_traditional_scalar_type() will be added, with this implementation
bool Type_handler::is_traditional_scalar_type() const
{
return type_collection() == &type_collection_std;
}
blocks
MDEV-4912
Data type plugin API version 1
Closed
Alexander Barkov
made changes -
2019-07-25 10:50
issue.field.resolutiondate
2019-07-25 10:50:54.0
2019-07-25 10:50:54.134
Alexander Barkov
made changes -
2019-07-25 10:50
Fix Version/s
10.5.0
[ 23709
]
Fix Version/s
10.5
[ 23123
]
Resolution
Fixed
[ 1
]
Status
Open
[ 1
]
Closed
[ 6
]
Sergei Golubchik
made changes -
2021-12-06 21:24
Workflow
MariaDB v3
[ 98503
]
MariaDB v4
[ 134053
]
{"report":{"fcp":1247.9000000953674,"ttfb":396.59999990463257,"pageVisibility":"visible","entityId":77800,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"d042a905-09e7-4ae3-8aa0-de210c52fff9","navigationType":0,"readyForUser":1346.5,"redirectCount":0,"resourceLoadedEnd":1403.9000000953674,"resourceLoadedStart":402.30000019073486,"resourceTiming":[{"duration":270.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":402.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":402.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":672.5,"responseStart":0,"secureConnectionStart":0},{"duration":271.69999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":402.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":402.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":674.1999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":328.7000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":402.69999980926514,"connectEnd":402.69999980926514,"connectStart":402.69999980926514,"domainLookupEnd":402.69999980926514,"domainLookupStart":402.69999980926514,"fetchStart":402.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":402.69999980926514,"responseEnd":731.4000000953674,"responseStart":731.4000000953674,"secureConnectionStart":402.69999980926514},{"duration":386.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":402.90000009536743,"connectEnd":402.90000009536743,"connectStart":402.90000009536743,"domainLookupEnd":402.90000009536743,"domainLookupStart":402.90000009536743,"fetchStart":402.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":402.90000009536743,"responseEnd":789.5999999046326,"responseStart":789.5999999046326,"secureConnectionStart":402.90000009536743},{"duration":390.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":403.19999980926514,"connectEnd":403.19999980926514,"connectStart":403.19999980926514,"domainLookupEnd":403.19999980926514,"domainLookupStart":403.19999980926514,"fetchStart":403.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":403.19999980926514,"responseEnd":793.6999998092651,"responseStart":793.6999998092651,"secureConnectionStart":403.19999980926514},{"duration":391,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":403.30000019073486,"connectEnd":403.30000019073486,"connectStart":403.30000019073486,"domainLookupEnd":403.30000019073486,"domainLookupStart":403.30000019073486,"fetchStart":403.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":403.30000019073486,"responseEnd":794.3000001907349,"responseStart":794.3000001907349,"secureConnectionStart":403.30000019073486},{"duration":391.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":403.5,"connectEnd":403.5,"connectStart":403.5,"domainLookupEnd":403.5,"domainLookupStart":403.5,"fetchStart":403.5,"redirectEnd":0,"redirectStart":0,"requestStart":403.5,"responseEnd":794.5999999046326,"responseStart":794.5999999046326,"secureConnectionStart":403.5},{"duration":473.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":403.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":403.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":877,"responseStart":0,"secureConnectionStart":0},{"duration":473.2999997138977,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":403.90000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":403.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":877.1999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":391.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":403.90000009536743,"connectEnd":403.90000009536743,"connectStart":403.90000009536743,"domainLookupEnd":403.90000009536743,"domainLookupStart":403.90000009536743,"fetchStart":403.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":403.90000009536743,"responseEnd":795,"responseStart":795,"secureConnectionStart":403.90000009536743},{"duration":391.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":404.09999990463257,"connectEnd":404.09999990463257,"connectStart":404.09999990463257,"domainLookupEnd":404.09999990463257,"domainLookupStart":404.09999990463257,"fetchStart":404.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":404.09999990463257,"responseEnd":795.6999998092651,"responseStart":795.6999998092651,"secureConnectionStart":404.09999990463257},{"duration":508.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":405,"connectEnd":405,"connectStart":405,"domainLookupEnd":405,"domainLookupStart":405,"fetchStart":405,"redirectEnd":0,"redirectStart":0,"requestStart":405,"responseEnd":913.3000001907349,"responseStart":913.3000001907349,"secureConnectionStart":405},{"duration":549.2000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":405.19999980926514,"connectEnd":405.19999980926514,"connectStart":405.19999980926514,"domainLookupEnd":405.19999980926514,"domainLookupStart":405.19999980926514,"fetchStart":405.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":405.19999980926514,"responseEnd":954.4000000953674,"responseStart":954.4000000953674,"secureConnectionStart":405.19999980926514},{"duration":31,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":888.6999998092651,"connectEnd":888.6999998092651,"connectStart":888.6999998092651,"domainLookupEnd":888.6999998092651,"domainLookupStart":888.6999998092651,"fetchStart":888.6999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":888.6999998092651,"responseEnd":919.6999998092651,"responseStart":919.6999998092651,"secureConnectionStart":888.6999998092651},{"duration":220.09999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":932.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":932.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1152.5999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":470.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":933.5,"connectEnd":933.5,"connectStart":933.5,"domainLookupEnd":933.5,"domainLookupStart":933.5,"fetchStart":933.5,"redirectEnd":0,"redirectStart":0,"requestStart":933.5,"responseEnd":1403.9000000953674,"responseStart":1403.9000000953674,"secureConnectionStart":933.5},{"duration":239.7000002861023,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1234.1999998092651,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1234.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1473.9000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":171.5,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1243.0999999046326,"connectEnd":1243.0999999046326,"connectStart":1243.0999999046326,"domainLookupEnd":1243.0999999046326,"domainLookupStart":1243.0999999046326,"fetchStart":1243.0999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":1243.0999999046326,"responseEnd":1414.5999999046326,"responseStart":1414.5999999046326,"secureConnectionStart":1243.0999999046326},{"duration":476.2999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":933.8000001907349,"connectEnd":933.8000001907349,"connectStart":933.8000001907349,"domainLookupEnd":933.8000001907349,"domainLookupStart":933.8000001907349,"fetchStart":933.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":933.8000001907349,"responseEnd":1410.0999999046326,"responseStart":1410.0999999046326,"secureConnectionStart":933.8000001907349}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":213,"responseStart":396,"responseEnd":400,"domLoading":400,"domInteractive":1410,"domContentLoadedEventStart":1410,"domContentLoadedEventEnd":1460,"domComplete":1643,"loadEventStart":1643,"loadEventEnd":1644,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1386.6999998092651},{"name":"bigPipe.sidebar-id.end","time":1387.5999999046326},{"name":"bigPipe.activity-panel-pipe-id.start","time":1387.6999998092651},{"name":"bigPipe.activity-panel-pipe-id.end","time":1389.6999998092651},{"name":"activityTabFullyLoaded","time":1487.5}],"measures":[],"correlationId":"8655a1b6dd530","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":122,"dbReadsTimeInMs":17,"dbConnsTimeInMs":28,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}