Details
-
Task
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
None
Description
https://en.cppreference.com/w/cpp/container/span
This should be used instead of a such arguments T *ptr, size_t size, const std::vector<T> &v.
Especially pointer and size pair is harmful: easy to use incorrect, hard to read the code.
Class is non-owning! It's just a reference to something.
Do not use it for strings! Another things exists for strings: https://en.cppreference.com/w/cpp/string/basic_string_view
Suggestion to use are here https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
| Description |
https://en.cppreference.com/w/cpp/container/span
This should be used instead of a such arguments {{T *ptr, size_t size}}, {{const std::vector<T> &v}}. Especially pointer and size pair is harmful: easy to use incorrect, hard to read the code. Class is non-owning! It's just a reference to something. Suggestion to use are here https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines |
https://en.cppreference.com/w/cpp/container/span
This should be used instead of a such arguments {{T *ptr, size_t size}}, {{const std::vector<T> &v}}. Especially pointer and size pair is harmful: easy to use incorrect, hard to read the code. Class is non-owning! It's just a reference to something. Do not use it for strings! Another things exists for strings: https://en.cppreference.com/w/cpp/string/basic_string_view Suggestion to use are here https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Assignee | Eugene Kosov [ kevg ] | Marko Mäkelä [ marko ] |
| Status | In Progress [ 3 ] | In Review [ 10002 ] |
| Assignee | Marko Mäkelä [ marko ] | Eugene Kosov [ kevg ] |
| Status | In Review [ 10002 ] | Stalled [ 10000 ] |
| Component/s | Storage Engine - InnoDB [ 10129 ] | |
| Fix Version/s | 10.2.27 [ 23717 ] | |
| Fix Version/s | 10.3.18 [ 23719 ] | |
| Fix Version/s | 10.4.8 [ 23721 ] | |
| Fix Version/s | 10.2 [ 14601 ] | |
| Fix Version/s | 10.3 [ 22126 ] | |
| Fix Version/s | 10.4 [ 22408 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | Stalled [ 10000 ] | Closed [ 6 ] |
| Workflow | MariaDB v3 [ 98357 ] | MariaDB v4 [ 134048 ] |