Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-20053

galera_recovery: Wrong @sbindir@

Details

    Description

      The (c)make scripts generate a wrong sbindir path.
      With
      -DCMAKE_INSTALL_PREFIX=/usr
      -DINSTALL_SCRIPTDIR=bin

      It generates an sbindir in galera_recovery of "./bin", which breaks galera_recovery, because "./bin" is a relative path to the current working directory. If the wd of the calling process is not /, then the script breaks at that point.

      Build files are available at https://git.archlinux.org/svntogit/packages.git/tree/trunk?h=packages/mariadb

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-12301 Use macro in scripts/galera_recovery.sh

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            thermi Noel Kuntze created issue -
            thermi Noel Kuntze made changes -
            Field Original Value New Value
            elenst Elena Stepanova made changes -
            Component/s Galera [ 10124 ]
            Component/s Packaging [ 10700 ]
            Fix Version/s 10.4 [ 22408 ]
            Assignee Jan Lindström [ jplindst ]
            Priority Blocker [ 1 ] Critical [ 2 ]
            jplindst Jan Lindström (Inactive) added a comment -

            I do not have Arch Linux easily available so can you explain why @sbindir@ is incorrect ?

            jplindst Jan Lindström (Inactive) added a comment - I do not have Arch Linux easily available so can you explain why @sbindir@ is incorrect ?
            jplindst Jan Lindström (Inactive) made changes -
            Priority Critical [ 2 ] Major [ 3 ]
            jplindst Jan Lindström (Inactive) made changes -
            Labels need_feedback
            thermi Noel Kuntze added a comment -

            The problem is a general one, not specific to Arch.
            The generated sbindir has to be "/usr/bin" (meaning the PREFIX has to be applied, too!) with the aforementioned parameters. Otherwise galera_recovery will fail if the current directory (working directory) is not the root directory, because the relative path "./bin" is not equal to "/bin".

            thermi Noel Kuntze added a comment - The problem is a general one, not specific to Arch. The generated sbindir has to be "/usr/bin" (meaning the PREFIX has to be applied, too!) with the aforementioned parameters. Otherwise galera_recovery will fail if the current directory (working directory) is not the root directory, because the relative path "./bin" is not equal to "/bin".
            elenst Elena Stepanova made changes -
            Labels need_feedback
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 98197 ] MariaDB v4 [ 141402 ]
            eworm Christian Hesse added a comment -

            The prefix is added only if `INSTALL_LAYOUT` matches "`STANDALONE`".
            This comes from `scripts/CMakeLists.txt`, starting around line 189.

            eworm Christian Hesse added a comment - The prefix is added only if `INSTALL_LAYOUT` matches "`STANDALONE`". This comes from `scripts/CMakeLists.txt`, starting around line 189.
            thermi Noel Kuntze added a comment -

            New link to files used to build mariadb for Arch: https://github.com/archlinux/svntogit-packages/blob/master/mariadb/trunk/PKGBUILD

            thermi Noel Kuntze added a comment - New link to files used to build mariadb for Arch: https://github.com/archlinux/svntogit-packages/blob/master/mariadb/trunk/PKGBUILD
            janlindstrom Jan Lindström made changes -
            Assignee Jan Lindström [ jplindst ] Julius Goryavsky [ sysprg ]
            eworm Christian Hesse added a comment -

            https://github.com/MariaDB/server/pull/3325

            eworm Christian Hesse added a comment - https://github.com/MariaDB/server/pull/3325
            danblack Daniel Black made changes -
            issue.field.resolutiondate 2024-06-22 07:26:14.0 2024-06-22 07:26:14.256
            danblack Daniel Black made changes -
            Fix Version/s 10.5.26 [ 29832 ]
            Fix Version/s 10.4 [ 22408 ]
            Assignee Julius Goryavsky [ sysprg ] Daniel Black [ danblack ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            JIraAutomate JiraAutomate made changes -
            Fix Version/s 10.6.19 [ 29833 ]
            Fix Version/s 10.11.9 [ 29834 ]
            Fix Version/s 11.1.6 [ 29835 ]
            Fix Version/s 11.2.5 [ 29836 ]
            Fix Version/s 11.4.3 [ 29837 ]

            People

              danblack Daniel Black
              thermi Noel Kuntze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.