Details

    Description

      The (c)make scripts generate a wrong sbindir path.
      With
      -DCMAKE_INSTALL_PREFIX=/usr
      -DINSTALL_SCRIPTDIR=bin

      It generates an sbindir in galera_recovery of "./bin", which breaks galera_recovery, because "./bin" is a relative path to the current working directory. If the wd of the calling process is not /, then the script breaks at that point.

      Build files are available at https://git.archlinux.org/svntogit/packages.git/tree/trunk?h=packages/mariadb

      Attachments

        Issue Links

          Activity

            I do not have Arch Linux easily available so can you explain why @sbindir@ is incorrect ?

            jplindst Jan Lindström (Inactive) added a comment - I do not have Arch Linux easily available so can you explain why @sbindir@ is incorrect ?
            thermi Noel Kuntze added a comment -

            The problem is a general one, not specific to Arch.
            The generated sbindir has to be "/usr/bin" (meaning the PREFIX has to be applied, too!) with the aforementioned parameters. Otherwise galera_recovery will fail if the current directory (working directory) is not the root directory, because the relative path "./bin" is not equal to "/bin".

            thermi Noel Kuntze added a comment - The problem is a general one, not specific to Arch. The generated sbindir has to be "/usr/bin" (meaning the PREFIX has to be applied, too!) with the aforementioned parameters. Otherwise galera_recovery will fail if the current directory (working directory) is not the root directory, because the relative path "./bin" is not equal to "/bin".

            The prefix is added only if `INSTALL_LAYOUT` matches "`STANDALONE`".
            This comes from `scripts/CMakeLists.txt`, starting around line 189.

            eworm Christian Hesse added a comment - The prefix is added only if `INSTALL_LAYOUT` matches "`STANDALONE`". This comes from `scripts/CMakeLists.txt`, starting around line 189.
            thermi Noel Kuntze added a comment - New link to files used to build mariadb for Arch: https://github.com/archlinux/svntogit-packages/blob/master/mariadb/trunk/PKGBUILD
            eworm Christian Hesse added a comment - https://github.com/MariaDB/server/pull/3325

            People

              danblack Daniel Black
              thermi Noel Kuntze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.