Type:
Task
Priority:
Major
Resolution:
Fixed
Let's add a new class with approximately this definition:
class Type_collection
{
public :
virtual ~Type_collection() {}
virtual const Type_handler *aggregate_for_result( const Type_handler *h1,
const Type_handler *h2)
const = 0;
virtual const Type_handler *aggregate_for_comparison( const Type_handler *h1,
const Type_handler *h2)
const = 0;
virtual const Type_handler *aggregate_for_min_max( const Type_handler *h1,
const Type_handler *h2)
const = 0;
virtual const Type_handler *aggregate_for_num_op( const Type_handler *h1,
const Type_handler *h2)
const = 0;
};
It will work as follows:
Data type plugins will provide instances of Type_collection.
Each Type_collection will contain one or more data types (Type_handler instances).
Data types from the same Type_collection will "know" each other.
If two data types are from the same collection, data type aggregation for various operations (i.e. result, comparson, LEAST/GREATES, numeric dyadic operators) will be delegated to their Type_collection through virtual methods.
For now there will be two collections:
Type_collection_geometry, containing Type_handler_geometry.
Type_collection_std, containing all other built-in data types.
Later, we'll split out geometry subtypes (POINT, LINESTRING, POLYGON, MULTIPOINT, MULTILINESTRING, MULTIPOLYGON, GEOMETRYCOLLECTION) into separate type handlers, so Type_collection_geometry will contain 8 type handlers
(the generic one, and handlers for 7 subtypes):
Type_handler_geometry
Type_handler_point
Type_handler_linestring
Type_handler_polygon
Type_handler_multipoint
Type_handler_multilinestring
Type_handler_multipolygon
Type_handler_geometrycollection
Later, we'll add Type_collection_json and will turn JSON functionality into handlers:
Type_handler_varchar_json
Type_handler_tinytext_json
Type_handler_text_json
Type_handler_mediumtext_json
Type_handler_longtext_json
and remove Item::is_json_type().
Later, we'll add Type_collection_inet with two data type handlers:
Type_handler_inet4
Type_handler_inet6
Transition
Time In Source Status
Execution Times
Open
Closed
12h 15m
1
{"report":{"fcp":1049.3000001907349,"ttfb":357.80000019073486,"pageVisibility":"visible","entityId":77147,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"e92e52a0-aefb-499d-833c-93d22ed3ab54","navigationType":0,"readyForUser":1122.8000001907349,"redirectCount":0,"resourceLoadedEnd":851.5,"resourceLoadedStart":363,"resourceTiming":[{"duration":125.20000076293945,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":363,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":363,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":488.20000076293945,"responseStart":0,"secureConnectionStart":0},{"duration":125.39999961853027,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":363.20000076293945,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":363.20000076293945,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":488.6000003814697,"responseStart":0,"secureConnectionStart":0},{"duration":229.89999961853027,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":363.4000005722046,"connectEnd":490.9000005722046,"connectStart":490.9000005722046,"domainLookupEnd":490.9000005722046,"domainLookupStart":490.9000005722046,"fetchStart":363.4000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":491.20000076293945,"responseEnd":593.3000001907349,"responseStart":502.70000076293945,"secureConnectionStart":490.9000005722046},{"duration":261.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":363.6000003814697,"connectEnd":363.6000003814697,"connectStart":363.6000003814697,"domainLookupEnd":363.6000003814697,"domainLookupStart":363.6000003814697,"fetchStart":363.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":492.70000076293945,"responseEnd":625.1000003814697,"responseStart":505.80000019073486,"secureConnectionStart":363.6000003814697},{"duration":148.60000038146973,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":363.80000019073486,"connectEnd":363.80000019073486,"connectStart":363.80000019073486,"domainLookupEnd":363.80000019073486,"domainLookupStart":363.80000019073486,"fetchStart":363.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":493.9000005722046,"responseEnd":512.4000005722046,"responseStart":510.6000003814697,"secureConnectionStart":363.80000019073486},{"duration":157.39999961853027,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":363.9000005722046,"connectEnd":363.9000005722046,"connectStart":363.9000005722046,"domainLookupEnd":363.9000005722046,"domainLookupStart":363.9000005722046,"fetchStart":363.9000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":494.9000005722046,"responseEnd":521.3000001907349,"responseStart":517.4000005722046,"secureConnectionStart":363.9000005722046},{"duration":159.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":364.1000003814697,"connectEnd":364.1000003814697,"connectStart":364.1000003814697,"domainLookupEnd":364.1000003814697,"domainLookupStart":364.1000003814697,"fetchStart":364.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":496.5,"responseEnd":523.9000005722046,"responseStart":519.4000005722046,"secureConnectionStart":364.1000003814697},{"duration":131,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":364.20000076293945,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":364.20000076293945,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":495.20000076293945,"responseStart":0,"secureConnectionStart":0},{"duration":159.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":364.4000005722046,"connectEnd":364.4000005722046,"connectStart":364.4000005722046,"domainLookupEnd":364.4000005722046,"domainLookupStart":364.4000005722046,"fetchStart":364.4000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":498.6000003814697,"responseEnd":524.2000007629395,"responseStart":521.5,"secureConnectionStart":364.4000005722046},{"duration":132.39999961853027,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":364.6000003814697,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":364.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":497,"responseStart":0,"secureConnectionStart":0},{"duration":159.89999961853027,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":364.70000076293945,"connectEnd":364.70000076293945,"connectStart":364.70000076293945,"domainLookupEnd":364.70000076293945,"domainLookupStart":364.70000076293945,"fetchStart":364.70000076293945,"redirectEnd":0,"redirectStart":0,"requestStart":499.4000005722046,"responseEnd":524.6000003814697,"responseStart":522.6000003814697,"secureConnectionStart":364.70000076293945},{"duration":475.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":376.1000003814697,"connectEnd":376.1000003814697,"connectStart":376.1000003814697,"domainLookupEnd":376.1000003814697,"domainLookupStart":376.1000003814697,"fetchStart":376.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":541.1000003814697,"responseEnd":851.3000001907349,"responseStart":845.9000005722046,"secureConnectionStart":376.1000003814697},{"duration":475.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":376.30000019073486,"connectEnd":376.30000019073486,"connectStart":376.30000019073486,"domainLookupEnd":376.30000019073486,"domainLookupStart":376.30000019073486,"fetchStart":376.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":623.4000005722046,"responseEnd":851.5,"responseStart":847.4000005722046,"secureConnectionStart":376.30000019073486},{"duration":232.5,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":787.6000003814697,"connectEnd":787.6000003814697,"connectStart":787.6000003814697,"domainLookupEnd":787.6000003814697,"domainLookupStart":787.6000003814697,"fetchStart":787.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":987.3000001907349,"responseEnd":1020.1000003814697,"responseStart":1019.5,"secureConnectionStart":787.6000003814697}],"fetchStart":0,"domainLookupStart":146,"domainLookupEnd":170,"connectStart":170,"connectEnd":191,"secureConnectionStart":178,"requestStart":191,"responseStart":358,"responseEnd":376,"domLoading":361,"domInteractive":1176,"domContentLoadedEventStart":1176,"domContentLoadedEventEnd":1211,"domComplete":1914,"loadEventStart":1914,"loadEventEnd":1915,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1160},{"name":"bigPipe.sidebar-id.end","time":1160.8000001907349},{"name":"bigPipe.activity-panel-pipe-id.start","time":1160.9000005722046},{"name":"bigPipe.activity-panel-pipe-id.end","time":1161.8000001907349},{"name":"activityTabFullyLoaded","time":1226.9000005722046}],"measures":[],"correlationId":"eb1ae3d2fee746","effectiveType":"4g","downlink":9.3,"rtt":0,"serverDuration":107,"dbReadsTimeInMs":17,"dbConnsTimeInMs":26,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}