Type:
Task
Priority:
Major
Resolution:
Fixed
Let's add a new class with approximately this definition:
class Type_collection
{
public :
virtual ~Type_collection() {}
virtual const Type_handler *aggregate_for_result( const Type_handler *h1,
const Type_handler *h2)
const = 0;
virtual const Type_handler *aggregate_for_comparison( const Type_handler *h1,
const Type_handler *h2)
const = 0;
virtual const Type_handler *aggregate_for_min_max( const Type_handler *h1,
const Type_handler *h2)
const = 0;
virtual const Type_handler *aggregate_for_num_op( const Type_handler *h1,
const Type_handler *h2)
const = 0;
};
It will work as follows:
Data type plugins will provide instances of Type_collection.
Each Type_collection will contain one or more data types (Type_handler instances).
Data types from the same Type_collection will "know" each other.
If two data types are from the same collection, data type aggregation for various operations (i.e. result, comparson, LEAST/GREATES, numeric dyadic operators) will be delegated to their Type_collection through virtual methods.
For now there will be two collections:
Type_collection_geometry, containing Type_handler_geometry.
Type_collection_std, containing all other built-in data types.
Later, we'll split out geometry subtypes (POINT, LINESTRING, POLYGON, MULTIPOINT, MULTILINESTRING, MULTIPOLYGON, GEOMETRYCOLLECTION) into separate type handlers, so Type_collection_geometry will contain 8 type handlers
(the generic one, and handlers for 7 subtypes):
Type_handler_geometry
Type_handler_point
Type_handler_linestring
Type_handler_polygon
Type_handler_multipoint
Type_handler_multilinestring
Type_handler_multipolygon
Type_handler_geometrycollection
Later, we'll add Type_collection_json and will turn JSON functionality into handlers:
Type_handler_varchar_json
Type_handler_tinytext_json
Type_handler_text_json
Type_handler_mediumtext_json
Type_handler_longtext_json
and remove Item::is_json_type().
Later, we'll add Type_collection_inet with two data type handlers:
Type_handler_inet4
Type_handler_inet6
{"report":{"fcp":979.5999999046326,"ttfb":325.39999985694885,"pageVisibility":"visible","entityId":77147,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"38f729a1-110c-499a-9746-b409fa43c18b","navigationType":0,"readyForUser":1056.2000000476837,"redirectCount":0,"resourceLoadedEnd":1035.3999998569489,"resourceLoadedStart":331,"resourceTiming":[{"duration":172.20000004768372,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":331,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":331,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":503.2000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":172.20000004768372,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":331.2999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":331.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":503.5,"responseStart":0,"secureConnectionStart":0},{"duration":181.20000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":331.5,"connectEnd":331.5,"connectStart":331.5,"domainLookupEnd":331.5,"domainLookupStart":331.5,"fetchStart":331.5,"redirectEnd":0,"redirectStart":0,"requestStart":331.5,"responseEnd":512.7000000476837,"responseStart":512.7000000476837,"secureConnectionStart":331.5},{"duration":236.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":331.7000000476837,"connectEnd":331.7000000476837,"connectStart":331.7000000476837,"domainLookupEnd":331.7000000476837,"domainLookupStart":331.7000000476837,"fetchStart":331.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":331.7000000476837,"responseEnd":568.2000000476837,"responseStart":568.2000000476837,"secureConnectionStart":331.7000000476837},{"duration":240.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":332,"connectEnd":332,"connectStart":332,"domainLookupEnd":332,"domainLookupStart":332,"fetchStart":332,"redirectEnd":0,"redirectStart":0,"requestStart":332,"responseEnd":572.0999999046326,"responseStart":572.0999999046326,"secureConnectionStart":332},{"duration":240.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":332.09999990463257,"connectEnd":332.09999990463257,"connectStart":332.09999990463257,"domainLookupEnd":332.09999990463257,"domainLookupStart":332.09999990463257,"fetchStart":332.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":332.09999990463257,"responseEnd":572.5,"responseStart":572.5,"secureConnectionStart":332.09999990463257},{"duration":240.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":332.2999999523163,"connectEnd":332.2999999523163,"connectStart":332.2999999523163,"domainLookupEnd":332.2999999523163,"domainLookupStart":332.2999999523163,"fetchStart":332.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":332.2999999523163,"responseEnd":572.8999998569489,"responseStart":572.8999998569489,"secureConnectionStart":332.2999999523163},{"duration":322.89999985694885,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":332.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":332.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":655.3999998569489,"responseStart":0,"secureConnectionStart":0},{"duration":240.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":332.59999990463257,"connectEnd":332.59999990463257,"connectStart":332.59999990463257,"domainLookupEnd":332.59999990463257,"domainLookupStart":332.59999990463257,"fetchStart":332.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":332.59999990463257,"responseEnd":573.3999998569489,"responseStart":573.3999998569489,"secureConnectionStart":332.59999990463257},{"duration":322.7999999523163,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":332.7999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":332.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":655.5999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":241.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":333,"connectEnd":333,"connectStart":333,"domainLookupEnd":333,"domainLookupStart":333,"fetchStart":333,"redirectEnd":0,"redirectStart":0,"requestStart":333,"responseEnd":574.0999999046326,"responseStart":574.0999999046326,"secureConnectionStart":333},{"duration":653.8999998569489,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":334,"connectEnd":334,"connectStart":334,"domainLookupEnd":334,"domainLookupStart":334,"fetchStart":334,"redirectEnd":0,"redirectStart":0,"requestStart":334,"responseEnd":987.8999998569489,"responseStart":987.8999998569489,"secureConnectionStart":334},{"duration":701.3999998569489,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":334,"connectEnd":334,"connectStart":334,"domainLookupEnd":334,"domainLookupStart":334,"fetchStart":334,"redirectEnd":0,"redirectStart":0,"requestStart":334,"responseEnd":1035.3999998569489,"responseStart":1035.3999998569489,"secureConnectionStart":334},{"duration":322.60000014305115,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":666.8999998569489,"connectEnd":666.8999998569489,"connectStart":666.8999998569489,"domainLookupEnd":666.8999998569489,"domainLookupStart":666.8999998569489,"fetchStart":666.8999998569489,"redirectEnd":0,"redirectStart":0,"requestStart":666.8999998569489,"responseEnd":989.5,"responseStart":989.5,"secureConnectionStart":666.8999998569489},{"duration":155,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":973.0999999046326,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":973.0999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1128.0999999046326,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":172,"responseStart":325,"responseEnd":326,"domLoading":328,"domInteractive":1196,"domContentLoadedEventStart":1196,"domContentLoadedEventEnd":1245,"domComplete":2068,"loadEventStart":2068,"loadEventEnd":2070,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1172.7000000476837},{"name":"bigPipe.sidebar-id.end","time":1173.7000000476837},{"name":"bigPipe.activity-panel-pipe-id.start","time":1174.2999999523163},{"name":"bigPipe.activity-panel-pipe-id.end","time":1177.0999999046326},{"name":"activityTabFullyLoaded","time":1252.3999998569489}],"measures":[],"correlationId":"a751b760a7d238","effectiveType":"4g","downlink":9.3,"rtt":0,"serverDuration":90,"dbReadsTimeInMs":9,"dbConnsTimeInMs":16,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}