Type:
Task
Priority:
Critical
Resolution:
Fixed
As part of MDEV-18777 new alias named "REPLICA" is added for "SLAVE".
One possible option is to add a new member to Lex to capture the name specified for
secondary server.
Like thd->lex->secondary_name= SLAVE/REPLICA. But there are following limitations
in implementing this solution.
LEX is so huge, it uses a lot of memory.
Inside SP, many statements, for example an assignment statement,
use their own LEX per statement. As a result, stored procedures use too
much memory. Also, LEX initialization is very expensive. Currently
server spends too much CPU to initalize LEXes, especially in stored
procedures.
We're doing the other way around: remove all specific members from LEX.
Please do the following way:
1. Add a new class Sql_cmd_show_slave_status
2. Move this code:
case SQLCOM_SHOW_SLAVE_STAT:
{
...
}
from mysql_execute_command() to Sql_cmd_show_slave_status::execute().
3. Add a new member which will distinguish between SLAVE and REPLICA
into this new class Sql_cmd_show_slave_status, instead of LEX.
4. Adjust the rest of the code to use the new class instead
of a "case" in mysql_execute_command().
For example, add "new Sql_cmd_show_slave_status" into sql_yacc.yy and sql_yacc_ora.yy
Please also add a member "verbose" in Sql_cmd_show_slave_status
and use it instead of LEX::verbose for SHOW SLAVE purposes.
blocks
MDEV-18777
Rename or alias slave-related statements, options, status variables
Stalled
{"report":{"fcp":850,"ttfb":198.39999997615814,"pageVisibility":"visible","entityId":77016,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"1115fa21-1406-40c3-8eb2-a1763c122af8","navigationType":0,"readyForUser":921.5,"redirectCount":0,"resourceLoadedEnd":1141.699999988079,"resourceLoadedStart":204.39999997615814,"resourceTiming":[{"duration":162.20000004768372,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":204.39999997615814,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":204.39999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":366.60000002384186,"responseStart":0,"secureConnectionStart":0},{"duration":162.19999998807907,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":204.69999998807907,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":204.69999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":366.89999997615814,"responseStart":0,"secureConnectionStart":0},{"duration":171.5999999642372,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":204.80000001192093,"connectEnd":204.80000001192093,"connectStart":204.80000001192093,"domainLookupEnd":204.80000001192093,"domainLookupStart":204.80000001192093,"fetchStart":204.80000001192093,"redirectEnd":0,"redirectStart":0,"requestStart":204.80000001192093,"responseEnd":376.39999997615814,"responseStart":376.39999997615814,"secureConnectionStart":204.80000001192093},{"duration":232.69999998807907,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":205.10000002384186,"connectEnd":205.10000002384186,"connectStart":205.10000002384186,"domainLookupEnd":205.10000002384186,"domainLookupStart":205.10000002384186,"fetchStart":205.10000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":205.10000002384186,"responseEnd":437.80000001192093,"responseStart":437.80000001192093,"secureConnectionStart":205.10000002384186},{"duration":228.0999999642372,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":205.10000002384186,"connectEnd":205.10000002384186,"connectStart":205.10000002384186,"domainLookupEnd":205.10000002384186,"domainLookupStart":205.10000002384186,"fetchStart":205.10000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":205.10000002384186,"responseEnd":433.19999998807907,"responseStart":433.19999998807907,"secureConnectionStart":205.10000002384186},{"duration":233.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":205.39999997615814,"connectEnd":205.39999997615814,"connectStart":205.39999997615814,"domainLookupEnd":205.39999997615814,"domainLookupStart":205.39999997615814,"fetchStart":205.39999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":205.39999997615814,"responseEnd":438.89999997615814,"responseStart":438.89999997615814,"secureConnectionStart":205.39999997615814},{"duration":234.29999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":205.60000002384186,"connectEnd":205.60000002384186,"connectStart":205.60000002384186,"domainLookupEnd":205.60000002384186,"domainLookupStart":205.60000002384186,"fetchStart":205.60000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":205.60000002384186,"responseEnd":439.89999997615814,"responseStart":439.89999997615814,"secureConnectionStart":205.60000002384186},{"duration":312.69999998807907,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":205.69999998807907,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":205.69999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":518.3999999761581,"responseStart":0,"secureConnectionStart":0},{"duration":234.9000000357628,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":205.89999997615814,"connectEnd":205.89999997615814,"connectStart":205.89999997615814,"domainLookupEnd":205.89999997615814,"domainLookupStart":205.89999997615814,"fetchStart":205.89999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":205.89999997615814,"responseEnd":440.80000001192093,"responseStart":440.80000001192093,"secureConnectionStart":205.89999997615814},{"duration":312.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":206.10000002384186,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":206.10000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":518.6000000238419,"responseStart":0,"secureConnectionStart":0},{"duration":235.30000001192093,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":206.19999998807907,"connectEnd":206.19999998807907,"connectStart":206.19999998807907,"domainLookupEnd":206.19999998807907,"domainLookupStart":206.19999998807907,"fetchStart":206.19999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":206.19999998807907,"responseEnd":441.5,"responseStart":441.5,"secureConnectionStart":206.19999998807907},{"duration":431,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":207.10000002384186,"connectEnd":207.10000002384186,"connectStart":207.10000002384186,"domainLookupEnd":207.10000002384186,"domainLookupStart":207.10000002384186,"fetchStart":207.10000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":207.10000002384186,"responseEnd":638.1000000238419,"responseStart":638.1000000238419,"secureConnectionStart":207.10000002384186},{"duration":915.6000000238419,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":211.19999998807907,"connectEnd":211.19999998807907,"connectStart":211.19999998807907,"domainLookupEnd":211.19999998807907,"domainLookupStart":211.19999998807907,"fetchStart":211.19999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":211.19999998807907,"responseEnd":1126.800000011921,"responseStart":1126.800000011921,"secureConnectionStart":211.19999998807907},{"duration":110.19999998807907,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":529.6000000238419,"connectEnd":529.6000000238419,"connectStart":529.6000000238419,"domainLookupEnd":529.6000000238419,"domainLookupStart":529.6000000238419,"fetchStart":529.6000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":529.6000000238419,"responseEnd":639.8000000119209,"responseStart":639.8000000119209,"secureConnectionStart":529.6000000238419},{"duration":340.80000001192093,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":800.8999999761581,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":800.8999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1141.699999988079,"responseStart":0,"secureConnectionStart":0},{"duration":330.30000001192093,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":801.8999999761581,"connectEnd":801.8999999761581,"connectStart":801.8999999761581,"domainLookupEnd":801.8999999761581,"domainLookupStart":801.8999999761581,"fetchStart":801.8999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":801.8999999761581,"responseEnd":1132.199999988079,"responseStart":1132.199999988079,"secureConnectionStart":801.8999999761581},{"duration":336.30000001192093,"initiatorType":"script","name":"https://jira.mariadb.org/s/f51ef5507eea4c158f257c66c93b2a3f-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":802.3999999761581,"connectEnd":802.3999999761581,"connectStart":802.3999999761581,"domainLookupEnd":802.3999999761581,"domainLookupStart":802.3999999761581,"fetchStart":802.3999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":802.3999999761581,"responseEnd":1138.699999988079,"responseStart":1138.699999988079,"secureConnectionStart":802.3999999761581},{"duration":304.60000002384186,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":843.3999999761581,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":843.3999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1148,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":51,"responseStart":199,"responseEnd":204,"domLoading":202,"domInteractive":1151,"domContentLoadedEventStart":1151,"domContentLoadedEventEnd":1192,"domComplete":1454,"loadEventStart":1454,"loadEventEnd":1455,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1129.3999999761581},{"name":"bigPipe.sidebar-id.end","time":1130.300000011921},{"name":"bigPipe.activity-panel-pipe-id.start","time":1130.5},{"name":"bigPipe.activity-panel-pipe-id.end","time":1131.699999988079},{"name":"activityTabFullyLoaded","time":1206.5}],"measures":[],"correlationId":"ef6bb634a15626","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":88,"dbReadsTimeInMs":10,"dbConnsTimeInMs":18,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Hello Bar,
Can you please review the changes for
MDEV-19855.BB link: http://buildbot.askmonty.org/buildbot/grid?category=main&branch=bb-10.5-sujatha
The patch is available in commit email list.
Thank you.