Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19712

Backup stage queries commented out in mariabackup's backup_mysql.cc

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 10.4.5
    • Fix Version/s: 10.4
    • Component/s: Backup
    • Labels:
      None

      Description

      I noticed that mariabackup's backup_mysql.cc contains some backup stage queries commented out:

      	xb_mysql_query(connection, "BACKUP STAGE START", true);
      	//xb_mysql_query(connection, "BACKUP STAGE FLUSH", true);
      	//xb_mysql_query(connection, "BACKUP STAGE BLOCK_DDL", true);
      	xb_mysql_query(connection, "BACKUP STAGE BLOCK_COMMIT", true);
      

      https://github.com/MariaDB/server/blob/mariadb-10.4.5/extra/mariabackup/backup_mysql.cc#L904

      If these are not needed, then maybe they should be removed?

      If these should be left for some reason, then maybe a comment could be added that explains why they are commented out?

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                vlad.lesin Vladislav Lesin
                Reporter:
                GeoffMontee Geoff Montee
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: