Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19712

Backup stage queries commented out in mariabackup's backup_mysql.cc

    XMLWordPrintable

Details

    Description

      I noticed that mariabackup's backup_mysql.cc contains some backup stage queries commented out:

      	xb_mysql_query(connection, "BACKUP STAGE START", true);
      		 
      	//xb_mysql_query(connection, "BACKUP STAGE FLUSH", true);
      		 
      	//xb_mysql_query(connection, "BACKUP STAGE BLOCK_DDL", true);
      		 
      	xb_mysql_query(connection, "BACKUP STAGE BLOCK_COMMIT", true);

      https://github.com/MariaDB/server/blob/mariadb-10.4.5/extra/mariabackup/backup_mysql.cc#L904

      If these are not needed, then maybe they should be removed?

      If these should be left for some reason, then maybe a comment could be added that explains why they are commented out?

      Attachments

        Issue Links

          is caused by

          Task - A task that needs to be done. MDEV-17308 BACKUP: mariabackup support

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-5336 Implement BACKUP STAGE for safe external backups

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            People

              wlad Vladislav Vaintroub
              GeoffMontee Geoff Montee (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.