[MDEV-19712] Backup stage queries commented out in mariabackup's backup_mysql.cc Created: 2019-06-07  Updated: 2021-08-19  Resolved: 2021-08-19

Status: Closed
Project: MariaDB Server
Component/s: Backup
Affects Version/s: 10.4.5
Fix Version/s: 10.4.22, 10.5.13, 10.6.5

Type: Bug Priority: Major
Reporter: Geoff Montee (Inactive) Assignee: Vladislav Vaintroub
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Problem/Incident
is caused by MDEV-17308 BACKUP: mariabackup support Closed
Relates
relates to MDEV-5336 Implement BACKUP STAGE for safe exter... Closed

 Description   

I noticed that mariabackup's backup_mysql.cc contains some backup stage queries commented out:

	xb_mysql_query(connection, "BACKUP STAGE START", true);
 
	//xb_mysql_query(connection, "BACKUP STAGE FLUSH", true);
 
	//xb_mysql_query(connection, "BACKUP STAGE BLOCK_DDL", true);
 
	xb_mysql_query(connection, "BACKUP STAGE BLOCK_COMMIT", true);

https://github.com/MariaDB/server/blob/mariadb-10.4.5/extra/mariabackup/backup_mysql.cc#L904

If these are not needed, then maybe they should be removed?

If these should be left for some reason, then maybe a comment could be added that explains why they are commented out?

 Comments   
Comment by Vladislav Lesin [ 2021-07-06 ]

BACKUP STAGE BLOCK_COMMIT applies also BACKUP STAGE FLUSH and BACKUP STAGE BLOCK_DDL. I think those lines were not deleted to remember about it when someone is reading the code.

Generated at Thu Feb 08 08:53:47 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.