Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19399

do not call slow my_timer_init() several times

Details

    Description

      my_thr_timer() call times() which is slow at least on my system. Maybe it's due to spectre mitigations, I don't know. Flame graph shows profiling data for empty test. Perfschema and InnoDB storage engines calls my_thr_timer() while both can actually use the one initialized by server.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          kevg Eugene Kosov (Inactive) added a comment -

          Attaching flame graph with a patch from PR too.

          kevg Eugene Kosov (Inactive) added a comment - Attaching flame graph with a patch from PR too.
          svoj Sergey Vojtovich added a comment -

          Already merged by marko

          svoj Sergey Vojtovich added a comment - Already merged by marko
          marko Marko Mäkelä added a comment -

          This looked trivial to me. Thanks!

          I wonder if we could remove the parameter of my_timer_init() and always let it initialize sys_timer_info.

          marko Marko Mäkelä added a comment - This looked trivial to me. Thanks! I wonder if we could remove the parameter of my_timer_init() and always let it initialize sys_timer_info .
          marko Marko Mäkelä added a comment -

          Unfortunately, the change caused link-time failures to resolve the global symbol sys_timer_info, and had to be reverted.

          marko Marko Mäkelä added a comment - Unfortunately, the change caused link-time failures to resolve the global symbol sys_timer_info , and had to be reverted.

          People

            kevg Eugene Kosov (Inactive)
            kevg Eugene Kosov (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.