Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19354

Rename Windows service name to MariaDB

Details

    Attachments

      Issue Links

        relates to

        Task - A task that needs to be done. MDEV-19358 Remove service registration code from mysqld.exe

        • Major - Major loss of function.
        • Closed

        Task - A task that needs to be done. MDEV-19068 Change Windows event source name to MariaDB

        • Major - Major loss of function.
        • Closed

        Activity

          Ascending order - Click to sort in descending order
          wlad Vladislav Vaintroub added a comment -

          I would like to reduce the scope of the change to only "default name in MSI installer GUI".

          changing this line https://github.com/MariaDB/server/blob/mariadb-10.4.4/include/mysql_com.h#L97 could be a breaking change, something that used to work before, would not work in the future .
          E.g currently, if mysqld.exe is started without parameters, currently it tries to start service "MySQL". if we change that to MariaDB, it will break.

          In 10.5 , I would like to remove the self-registration via "mysqld --install", "mysqld --remove", and also the behaviour described in previous sentence (i.e I would not like to perform magic lookup for the MySQL or MariaDB service, or any service, if mysqld was not definitely registered as service)

          wlad Vladislav Vaintroub added a comment - I would like to reduce the scope of the change to only "default name in MSI installer GUI". changing this line https://github.com/MariaDB/server/blob/mariadb-10.4.4/include/mysql_com.h#L97 could be a breaking change, something that used to work before, would not work in the future . E.g currently, if mysqld.exe is started without parameters, currently it tries to start service "MySQL". if we change that to MariaDB, it will break. In 10.5 , I would like to remove the self-registration via "mysqld --install", "mysqld --remove", and also the behaviour described in previous sentence (i.e I would not like to perform magic lookup for the MySQL or MariaDB service, or any service, if mysqld was not definitely registered as service)
          wlad Vladislav Vaintroub added a comment - - edited

          I hope to get rid of MYSQL_SERVICENAME completely in 10.5 with MDEV-19358.

          wlad Vladislav Vaintroub added a comment - - edited I hope to get rid of MYSQL_SERVICENAME completely in 10.5 with MDEV-19358 .

          People

            wlad Vladislav Vaintroub
            GeoffMontee Geoff Montee (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.