Details
-
Task
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
None
Description
New data types will introduce their own Field_xxx classes which will be implemented outside of field.cc.
To be able to do similar asserts in new Field_xxx, let's move the code from macros to methods in Field, like this:
inline bool Field::marked_for_read() const |
{
|
return !table || |
(!table->read_set ||
|
bitmap_is_set(table->read_set, field_index) ||
|
(!(ptr >= table->record[0] &&
|
ptr < table->record[0] + table->s->reclength)));
|
}
|
|
|
|
|
inline bool Field::marked_for_write_or_computed() const |
{
|
return is_stat_field || !table || |
(!table->write_set ||
|
bitmap_is_set(table->write_set, field_index) ||
|
(!(ptr >= table->record[0] &&
|
ptr < table->record[0] + table->s->reclength)));
|
}
|
Attachments
Issue Links
- blocks
-
MDEV-4912 Data type plugin API version 1
-
- Closed
-
- relates to
-
MDEV-19224 Assertion `marked_for_read()' failed in various places with long unique key
-
- Closed
-
Activity
| issue.field.resolutiondate | 2019-04-06 07:38:42.0 | 2019-04-06 07:38:42.6 |
| Fix Version/s | 10.4.4 [ 23310 ] | |
| Fix Version/s | 10.4 [ 22408 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | Open [ 1 ] | Closed [ 6 ] |
| Link |
This issue relates to |
| Workflow | MariaDB v3 [ 95254 ] | MariaDB v4 [ 133922 ] |