Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-18791

Wrong error upon creating Aria table with long index on BLOB

Details

    Description

      CREATE TABLE t1 (a TEXT, UNIQUE(a)) ENGINE=Aria;

      10.4 3b47587f

      		 
      mysqltest: At line 1: query 'CREATE TABLE t1 (a TEXT, UNIQUE(a)) ENGINE=Aria' failed: 1904: Key/Index cannot be defined on a virtual generated column

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-23530 ERROR 1071: Specified key was too long; max key length is 1000/2000 bytes on CREATE TABLE ... UNIQUE KEY ... USING HASH

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open
          is caused by

          Task - A task that needs to be done. MDEV-371 Unique indexes for blobs

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21057 CREATE UNIQUE INDEX USING HASH malfunctions for engine=Aria table

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20001 Potential dangerous regression: INSERT INTO >=100 rows fail for myisam table with HASH indexes

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-23530 ERROR 1071: Specified key was too long; max key length is 1000/2000 bytes on CREATE TABLE ... UNIQUE KEY ... USING HASH

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            sachin.setiya.007 Sachin Setiya (Inactive) added a comment -

            http://lists.askmonty.org/pipermail/commits/2019-June/013832.html

            sachin.setiya.007 Sachin Setiya (Inactive) added a comment - http://lists.askmonty.org/pipermail/commits/2019-June/013832.html
            monty Michael Widenius added a comment -

            The suggested bug fix is wrong:

            • It would change errors to "Aria Storage engine does not support long unique keys" that should not be changed.

            Please ensure that the patch doesn't change this:

            MariaDB [test]> create or replace table t1 (a varchar(251), b int generated always as (length(a)), key (b)) engine=aria;
            ERROR 1904 (HY000): Key/Index cannot be defined on a virtual generated column

            Adding an error handler is usually not the correct way to fix the issue. The correct way would be that when MariaDB decides to use a virtual hash column for unique handling, it should check if the storage engine supports indexes on virtual columns and give an error if this is not the case.

            monty Michael Widenius added a comment - The suggested bug fix is wrong: It would change errors to "Aria Storage engine does not support long unique keys" that should not be changed. Please ensure that the patch doesn't change this: MariaDB [test] > create or replace table t1 (a varchar(251), b int generated always as (length(a)), key (b)) engine=aria; ERROR 1904 (HY000): Key/Index cannot be defined on a virtual generated column Adding an error handler is usually not the correct way to fix the issue. The correct way would be that when MariaDB decides to use a virtual hash column for unique handling, it should check if the storage engine supports indexes on virtual columns and give an error if this is not the case.
            sachin.setiya.007 Sachin Setiya (Inactive) added a comment -

            Hi monty ,
            This commit addresses all the issues
            http://lists.askmonty.org/pipermail/commits/2019-August/013924.html

            sachin.setiya.007 Sachin Setiya (Inactive) added a comment - Hi monty , This commit addresses all the issues http://lists.askmonty.org/pipermail/commits/2019-August/013924.html
            serg Sergei Golubchik added a comment -

            ok to push

            serg Sergei Golubchik added a comment - ok to push

            People

              sachin.setiya.007 Sachin Setiya (Inactive)
              elenst Elena Stepanova
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.