Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-18650

Options deprecated in previous versions

Details

    Description

      According to the KB as of 2019-02-19, at least the following options / variables have been deprecated, but not mentioned as removed:

      option / variable first version where it was deprecated removed in 10.5 by
      --log-bin-trust-routine-creators 5.0.16 (MySQL) ? 5.5.20 alpha
      --delay-key-write-for-all-tables 5.0 (MySQL) 5.5.20 alpha
      --default-collation 5.0 (MySQL) 5.5.20 alpha
      --enable-locking 5.0 (MySQL) 5.5.20 alpha
      --log-long-format 5.0 (MySQL) 5.5.20 alpha
      --log-update 5.0 (MySQL) 5.5.20 alpha
      --one-thread ? MDEV-4865
      --set-variable 5.0 (MySQL) 5.5.20 alpha
      --skip-locking 5.0 (MySQL) 5.5.20 alpha
      --use-symbolic-links 5.0 (MySQL) 5.5.20 alpha
      --warnings 5.0 (MySQL) 5.5.20 alpha
      max_long_data_size 5.5 MDEV-7481
      multi_range_count 5.1, ignored from 5.3  
      optimizer_switch.engine_condition_pushdown 10.1.1  
      storage_engine 5.5 - in variable description, not with Warning MDEV-21475
      thread_concurrency 5.5  
      timed_mutexes 5.5.39  
      mroonga_default_parser mroonga 5.04  
      innodb_buffer_pool_populate 10.0.23  
      innodb_checksums 10.0 MDEV-19534
      innodb_cleaner_lsn_age_factor 10.2.6  
      innodb_corrupt_table_action 10.2.6  
      innodb_empty_free_list_algorithm 10.2.6  
      innodb_fake_changes 10.2.6  
      innodb_foreground_preflush 10.2.6  
      innodb_kill_idle_transaction 10.2.6  
      innodb_locking_fake_changes 10.2.6  
      innodb_locks_unsafe_for_binlog 10.0 MDEV-19544
      innodb_log_arch_dir 10.2.6  
      innodb_log_arch_expire_sec 10.2.6  
      innodb_log_archive 10.2.6  
      innodb_log_block_size 10.2.6  
      innodb_log_checksum_algorithm 10.2.6  
      innodb_max_bitmap_file_size 10.2.6  
      innodb_max_changed_pages 10.2.6  
      innodb_rollback_segments 10.0 MDEV-19570
      innodb_sched_priority_cleaner 10.2.6  
      innodb_show_locks_held 10.2.6  
      innodb_show_verbose_locks 10.2.6  
      innodb_stats_sample_pages 10.0 MDEV-19551
      innodb_track_changed_pages 10.2.6  
      innodb_track_redo_log_now 10.2.6  
      innodb_use_global_flush_log_at_trx_commit 10.2.6  
      innodb_use_stacktrace 10.2.6  

      At some point, a cleanup needs to be done: either we should remove them, or we should introduce a concept of eternal deprecation, when an option/variable is accepted on startup (with a warning), but is otherwise ignored – cannot be seen or set or used at runtime.

      Attachments

        Issue Links

          Activity

            A search for "unused" in this page reveals more variables (not sure if they were ever used):

            https://mariadb.com/kb/en/library/server-system-variables/

            f_razzoli Federico Razzoli added a comment - A search for "unused" in this page reveals more variables (not sure if they were ever used): https://mariadb.com/kb/en/library/server-system-variables/
            marko Marko Mäkelä added a comment - - edited

            MDEV-19570 will not only remove innodb_rollback_segments, but also deprecate and remove the ‘new’ name innodb_undo_logs. I do not see much point in having either parameter at all, but in my opinion the deprecated name is more descriptive and accurate, because a rollback segment may contain several undo logs (until MDEV-12288 up to 2 logs per persistent not-yet-purged transaction).

            marko Marko Mäkelä added a comment - - edited MDEV-19570 will not only remove innodb_rollback_segments , but also deprecate and remove the ‘new’ name innodb_undo_logs . I do not see much point in having either parameter at all, but in my opinion the deprecated name is more descriptive and accurate, because a rollback segment may contain several undo logs (until MDEV-12288 up to 2 logs per persistent not-yet-purged transaction).

            f_razzoli, thank you. The following ‘unused’ variables look like candidates for removal:

            • date_format (hard to search for, because there is a SQL function by the same name)
            • time_format
            • datetime_format
            • max_tmp_tables
            marko Marko Mäkelä added a comment - f_razzoli , thank you. The following ‘unused’ variables look like candidates for removal: date_format (hard to search for, because there is a SQL function by the same name) time_format datetime_format max_tmp_tables

            We might want to check if any of these parameters are ‘popular’, that is, they have been part of default or sample configuration files of GNU/Linux distributions. In MDEV-18399, I had to revert a too eager removal.

            The cleanup has already been completed in the InnoDB storage engine of MariaDB 10.5, except for the XtraDB-related deprecated parameters that were added to 10.2.6 in MDEV-12472. I think that those could be removed as well.

            marko Marko Mäkelä added a comment - We might want to check if any of these parameters are ‘popular’, that is, they have been part of default or sample configuration files of GNU/Linux distributions. In MDEV-18399 , I had to revert a too eager removal. The cleanup has already been completed in the InnoDB storage engine of MariaDB 10.5, except for the XtraDB-related deprecated parameters that were added to 10.2.6 in MDEV-12472 . I think that those could be removed as well.

            cvicentiu see https://github.com/MariaDB/server/commit/8884d99f89b5f4e7b9c0847a80adfda2994e9178 and https://github.com/MariaDB/server/commit/4d8d04c3617da1ed3acd4cb193a0880b6a5b5488

            I'm not going to push them into 10.5, as the second needs changes to tests and it'll conflict with your changes. But I suppose you can push them

            serg Sergei Golubchik added a comment - cvicentiu see https://github.com/MariaDB/server/commit/8884d99f89b5f4e7b9c0847a80adfda2994e9178 and https://github.com/MariaDB/server/commit/4d8d04c3617da1ed3acd4cb193a0880b6a5b5488 I'm not going to push them into 10.5, as the second needs changes to tests and it'll conflict with your changes. But I suppose you can push them

            serg Cherry-picked and incorporated into the work for this MDEV.

            cvicentiu Vicențiu Ciorbaru added a comment - serg Cherry-picked and incorporated into the work for this MDEV.

            People

              cvicentiu Vicențiu Ciorbaru
              elenst Elena Stepanova
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.