Details
Minor Description
Clauses like SET GLOBAL debug = ''; should be replaced with SET_GLOBAL debug_dbug=''; as debug variable is deprecated and using it causes unnecessary warnings to result files.
(1) Grep all galera tests that use debug variable and replace it with debug_dbug
(2) Re-record changed test results (./mtr test --record)
(3) Run whole test suite to avoid regressions
(4) Push all this to staging branch e.g. bb-10.1-MDEV-18265 and set this MDEV to request review from me.
(5) After review fix review comments and push to main tree.
Attachments
Activity
commit 622e9e8a7a5e9babe1dd41e7499c20f396b6ebdf (HEAD -> 10.1, origin/10.1)
Author: Jan Lindström <jan.lindstrom@mariadb.com>
Date: Wed Feb 27 13:15:03 2019 +0200
MDEV-18265: Replace deprecated variable debug to debug_dbug on Galera tests
Replaced debug to debug_dbug on 10.1 on galera suite. Nothing to do
in wsrep and galera_3nodes suites.
Merged above commit to 10.2 and now nothing more to do there.
This is for 10.4, there are still some .result files but as tests fail they are not yet updated.
commit fe62ff6e1c8d6931935a0f9a10613abf93e3668f (HEAD -> 10.4, origin/HEAD, origin/10.4)
|
Author: Jan Lindström <jan.lindstrom@mariadb.com>
|
Date: Sat Apr 6 12:25:29 2019 +0300
|
|
|
MDEV-18265: Replace deprecated variable debug to debug_dbug on Galera tests
|
|
deleted: mysql-test/suite/galera/r/MW-86.result
|
deleted: mysql-test/suite/galera/r/mysql-wsrep#216.result
|
modified: mysql-test/suite/galera/t/GCF-1081.test
|
modified: mysql-test/suite/galera_3nodes_sr/r/GCF-832.result
|
modified: mysql-test/suite/galera_3nodes_sr/t/GCF-810A.test
|
modified: mysql-test/suite/galera_3nodes_sr/t/GCF-810B.test
|
modified: mysql-test/suite/galera_3nodes_sr/t/GCF-810C.test
|
modified: mysql-test/suite/galera_3nodes_sr/t/GCF-832.test
|
modified: mysql-test/suite/galera_sr/r/mysql-wsrep-features#35.result
|
modified: mysql-test/suite/galera_sr/t/mysql-wsrep-features#35.test
|
Jan:
"You could start using 10.1 and galera/t/MW-86-wait1.test test case that uses e.g. MW-86-wait1.test:SET GLOBAL debug = "-d,sync.wsrep_apply_cb";, when you have updated the test case and re-recorded the result file can you show me the diff, there are other similar tests on that suite but lets start from one."