Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-17903

New optimizer defaults: change optimize_join_buffer_size to be ON

Details

    Description

      • From today's optimizer call:
        According to igor, the default setting for optimize_join_buffer_size should be ON.

      The first step is to enable the flag and run MTR.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-15253 Default optimizer setting changes for MariaDB 10.4

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            psergei Sergei Petrunia created issue -
            psergei Sergei Petrunia made changes -
            Field Original Value New Value
            psergei Sergei Petrunia made changes -
            Fix Version/s 10.4 [ 22408 ]
            psergei Sergei Petrunia made changes -
            Assignee Varun Gupta [ varun ]
            varun Varun Gupta (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            varun Varun Gupta (Inactive) added a comment -

            I made the patch and pushed it to buildbot, the results seem interesting for a 32 bit platforms
            https://buildbot.askmonty.org/buildbot/builders/win32-debug/builds/11958

            main.myisam_mrr                          w1 [ fail ]
            		 
                    Test ended at 2019-01-04 10:44:34
            		 
             
            		 
            CURRENT_TEST: main.myisam_mrr
            		 
            --- D:/win32-debug/build/src/mysql-test/main/myisam_mrr.result	2019-01-04 09:35:51.204610900 +0000
            		 
            +++ D:\win32-debug\build\src\mysql-test\main\myisam_mrr.reject	2019-01-04 10:44:33.554700600 +0000
            		 
            @@ -617,8 +617,8 @@
            		 
             show status like 'handler_mrr%';
            		 
             Variable_name	Value
            		 
             Handler_mrr_init	1
            		 
            -Handler_mrr_key_refills	1
            		 
            -Handler_mrr_rowid_refills	1
            		 
            +Handler_mrr_key_refills	0
            		 
            +Handler_mrr_rowid_refills	0

            While in the patch i checked and updated the result for myisam_mrr test for 64 bit machines
            https://github.com/MariaDB/server/commit/a6c077325117afdf22b93d711c9e78066edd123d

            show status like 'handler_mrr%';
            		 
            Variable_name	Value
            		 
            Handler_mrr_init	1
            		 
            -Handler_mrr_key_refills	0
            		 
            -Handler_mrr_rowid_refills	0
            		 
            +Handler_mrr_key_refills	1
            		 
            +Handler_mrr_rowid_refills	1

            So we see that the output for show status like 'handler_mrr%' varies on 32 bit and 64 machines

            varun Varun Gupta (Inactive) added a comment - I made the patch and pushed it to buildbot, the results seem interesting for a 32 bit platforms https://buildbot.askmonty.org/buildbot/builders/win32-debug/builds/11958 main.myisam_mrr w1 [ fail ] Test ended at 2019-01-04 10:44:34   CURRENT_TEST: main.myisam_mrr --- D:/win32-debug/build/src/mysql-test/main/myisam_mrr.result 2019-01-04 09:35:51.204610900 +0000 +++ D:\win32-debug\build\src\mysql-test\main\myisam_mrr.reject 2019-01-04 10:44:33.554700600 +0000 @@ -617,8 +617,8 @@ show status like 'handler_mrr%'; Variable_name Value Handler_mrr_init 1 -Handler_mrr_key_refills 1 -Handler_mrr_rowid_refills 1 +Handler_mrr_key_refills 0 +Handler_mrr_rowid_refills 0 While in the patch i checked and updated the result for myisam_mrr test for 64 bit machines https://github.com/MariaDB/server/commit/a6c077325117afdf22b93d711c9e78066edd123d show status like 'handler_mrr%'; Variable_name Value Handler_mrr_init 1 -Handler_mrr_key_refills 0 -Handler_mrr_rowid_refills 0 +Handler_mrr_key_refills 1 +Handler_mrr_rowid_refills 1 So we see that the output for show status like 'handler_mrr%' varies on 32 bit and 64 machines
            varun Varun Gupta (Inactive) added a comment -

            Patch
            https://github.com/MariaDB/server/commit/f180704255a458db18dfb734557981a1ca2f574e

            varun Varun Gupta (Inactive) added a comment - Patch https://github.com/MariaDB/server/commit/f180704255a458db18dfb734557981a1ca2f574e
            varun Varun Gupta (Inactive) made changes -
            Assignee Varun Gupta [ varun ] Sergei Petrunia [ psergey ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            psergei Sergei Petrunia made changes -
            Description From today's optimizer call:
            According to [~igor], the default setting for {{optimize_join_buffer_size}} should be ON.

            The first step is to enable the flag and run MTR.             		* From today's optimizer call:
            According to [~igor], the default setting for {{optimize_join_buffer_size}} should be ON.

            The first step is to enable the flag and run MTR.
            psergei Sergei Petrunia added a comment -

            Hi Varun, The patch is Ok to push.

            psergei Sergei Petrunia added a comment - Hi Varun, The patch is Ok to push.
            psergei Sergei Petrunia made changes -
            Assignee Sergei Petrunia [ psergey ] Varun Gupta [ varun ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            varun Varun Gupta (Inactive) made changes -
            Fix Version/s 10.4.3 [ 23230 ]
            Fix Version/s 10.4 [ 22408 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 91047 ] MariaDB v4 [ 133779 ]

            People

              varun Varun Gupta (Inactive)
              psergei Sergei Petrunia
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.