[MDEV-17903] New optimizer defaults: change optimize_join_buffer_size to be ON Created: 2018-12-04  Updated: 2019-02-19  Resolved: 2019-02-19

Status: Closed
Project: MariaDB Server
Component/s: Optimizer
Fix Version/s: 10.4.3

Type: Task Priority: Major
Reporter: Sergei Petrunia Assignee: Varun Gupta (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
relates to MDEV-15253 Default optimizer setting changes for... Closed

 Description   
  • From today's optimizer call:
    According to igor, the default setting for optimize_join_buffer_size should be ON.

The first step is to enable the flag and run MTR.

 Comments   
Comment by Varun Gupta (Inactive) [ 2019-01-07 ]

I made the patch and pushed it to buildbot, the results seem interesting for a 32 bit platforms
https://buildbot.askmonty.org/buildbot/builders/win32-debug/builds/11958

main.myisam_mrr                          w1 [ fail ]
 
        Test ended at 2019-01-04 10:44:34
 
 
 
CURRENT_TEST: main.myisam_mrr
 
--- D:/win32-debug/build/src/mysql-test/main/myisam_mrr.result	2019-01-04 09:35:51.204610900 +0000
 
+++ D:\win32-debug\build\src\mysql-test\main\myisam_mrr.reject	2019-01-04 10:44:33.554700600 +0000
 
@@ -617,8 +617,8 @@
 
 show status like 'handler_mrr%';
 
 Variable_name	Value
 
 Handler_mrr_init	1
 
-Handler_mrr_key_refills	1
 
-Handler_mrr_rowid_refills	1
 
+Handler_mrr_key_refills	0
 
+Handler_mrr_rowid_refills	0

While in the patch i checked and updated the result for myisam_mrr test for 64 bit machines
https://github.com/MariaDB/server/commit/a6c077325117afdf22b93d711c9e78066edd123d

show status like 'handler_mrr%';
 
Variable_name	Value
 
Handler_mrr_init	1
 
-Handler_mrr_key_refills	0
 
-Handler_mrr_rowid_refills	0
 
+Handler_mrr_key_refills	1
 
+Handler_mrr_rowid_refills	1

So we see that the output for show status like 'handler_mrr%' varies on 32 bit and 64 machines

Comment by Varun Gupta (Inactive) [ 2019-02-05 ]

Patch
https://github.com/MariaDB/server/commit/f180704255a458db18dfb734557981a1ca2f574e

Comment by Sergei Petrunia [ 2019-02-17 ]

Hi Varun, The patch is Ok to push.

Generated at Thu Feb 08 08:40:01 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.