Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-17705

Review InnoDB changes on Galera 4 wsrep patch

Details

    Attachments

      Issue Links

        Activity

          marko Marko Mäkelä added a comment - - edited

          One more question: How is sr_table_name_full_str supposed to work? I am a bit afraid that it might not work as intended when there exist FOREIGN KEY constraints, especially with CASCADE or SET NULL, attached to the table.

          I am afraid that sr_table_name_full_str might not work with partitioned tables. What is the logic there?

          marko Marko Mäkelä added a comment - - edited One more question: How is sr_table_name_full_str supposed to work? I am a bit afraid that it might not work as intended when there exist FOREIGN KEY constraints, especially with CASCADE or SET NULL , attached to the table. I am afraid that sr_table_name_full_str might not work with partitioned tables. What is the logic there?
          seppo Seppo Jaakola added a comment -

          all fake_trx_id references should be removed from the code by now

          seppo Seppo Jaakola added a comment - all fake_trx_id references should be removed from the code by now

          I just checked the diff for storage/innobase between 10.4 and the bb-10.4-galera4 once more today, and it looks OK from my perspective. I posted a few suggestions to the Slack channel, which would be nice to have.

          I think that sr_table_name_full_str should be changed from const std::string to const char* const, to avoid introducing an unnecessary constraint that Galera and MariaDB must be built with mutually compatible C++ compilers.

          That said, I think that the tests need some more attention and clean-up. But that also applies to the Galera 3 tests.

          marko Marko Mäkelä added a comment - I just checked the diff for storage/innobase between 10.4 and the bb-10.4-galera4 once more today, and it looks OK from my perspective. I posted a few suggestions to the Slack channel, which would be nice to have. I think that sr_table_name_full_str should be changed from const std::string to const char* const , to avoid introducing an unnecessary constraint that Galera and MariaDB must be built with mutually compatible C++ compilers. That said, I think that the tests need some more attention and clean-up. But that also applies to the Galera 3 tests.

          I submitted a pull request that changes the type of sr_table_name_full_str, and renamed it wsrep_sr_table_name_full

          https://github.com/MariaDB/server/pull/1102

          sciascid Daniele Sciascia added a comment - I submitted a pull request that changes the type of sr_table_name_full_str, and renamed it wsrep_sr_table_name_full https://github.com/MariaDB/server/pull/1102

          Fixed on branch bb-10.4-galera4

          jplindst Jan Lindström (Inactive) added a comment - Fixed on branch bb-10.4-galera4

          People

            jplindst Jan Lindström (Inactive)
            jplindst Jan Lindström (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.