Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.3(EOL)
-
None
-
Arch Linux, gcc8
Description
The CMake code of the tokudb build files sets and checks the following cflags:
set_cflags_if_supported(
|
-Wextra
|
-Wbad-function-cast
|
-Wno-missing-noreturn
|
-Wstrict-prototypes
|
-Wmissing-prototypes
|
-Wmissing-declarations
|
-Wpointer-arith
|
#-Wshadow will fail with GCC-8
|
${OPTIONAL_CFLAGS}
|
## other flags to try:
|
#-Wunsafe-loop-optimizations
|
#-Wpointer-arith
|
#-Wc++-compat
|
#-Wc++11-compat
|
#-Wwrite-strings
|
#-Wzero-as-null-pointer-constant
|
#-Wlogical-op
|
#-Wvector-optimization-performance
|
)
|
Of those, the following produce a warning with gcc8 with cause CMake to abort the compilation. Therefore they have to be removed. This pertains all versions. It probably does not trigger with old CMake versions or older gcc versions that do not print those warnings.
-Wbad-function-cast
|
-Wstrict-prototypes
|
-Wmissing-prototypes
|
Warnings:
|
cc1plus: warning: command line option '-Wbad-function-cast' is valid for C/ObjC but not for C++
|
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
|
cc1plus: warning: command line option '-Wmissing-prototypes' is valid for C/ObjC but not for C++
|
Attachments
Issue Links
- duplicates
-
-
- Closed
-
- relates to
-
-
- Closed
-
- links to
Activity
| Field | Original Value | New Value |
|---|---|---|
| Component/s | Storage Engine - TokuDB [ 10134 ] |
| Fix Version/s | 10.3 [ 22126 ] | |
| Affects Version/s | 10.3 [ 22126 ] | |
| Assignee | Sergei Golubchik [ serg ] |
| Fix Version/s | 10.4 [ 22408 ] |
| Link |
This issue relates to |
| Link |
This issue relates to |
| Link |
This issue relates to |
| Status | Open [ 1 ] | Confirmed [ 10101 ] |
| Assignee | Sergei Golubchik [ serg ] | Anel Husakovic [ anel ] |
| Assignee | Anel Husakovic [ anel ] | Vladislav Vaintroub [ wlad ] |
| Status | Confirmed [ 10101 ] | In Review [ 10002 ] |
| Link |
This issue relates to |
| Link |
This issue relates to |
| Remote Link | This issue links to "PR #1318 (Web Link)" [ 29021 ] |
| Attachment | CMakeOutput.log [ 48176 ] |
| Attachment | CMakeError.log [ 48177 ] |
| issue.field.resolutiondate | 2019-06-05 17:44:24.0 | 2019-06-05 17:44:24.149 |
| Fix Version/s | 10.1.41 [ 23406 ] | |
| Fix Version/s | 10.2.25 [ 23408 ] | |
| Fix Version/s | 10.3.16 [ 23410 ] | |
| Fix Version/s | 10.4.6 [ 23412 ] | |
| Fix Version/s | 10.3 [ 22126 ] | |
| Fix Version/s | 10.4 [ 22408 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | In Review [ 10002 ] | Closed [ 6 ] |
| Link |
This issue duplicates |
| Workflow | MariaDB v3 [ 89168 ] | MariaDB v4 [ 154876 ] |