Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-17103

tokudb doesn't build with gcc8 due to warning

    Details

      Description

      The CMake code of the tokudb build files sets and checks the following cflags:

      set_cflags_if_supported(
        -Wextra
        -Wbad-function-cast
        -Wno-missing-noreturn
        -Wstrict-prototypes
        -Wmissing-prototypes
        -Wmissing-declarations
        -Wpointer-arith
        #-Wshadow will fail with GCC-8
        ${OPTIONAL_CFLAGS}
        ## other flags to try:
        #-Wunsafe-loop-optimizations
        #-Wpointer-arith
        #-Wc++-compat
        #-Wc++11-compat
        #-Wwrite-strings
        #-Wzero-as-null-pointer-constant
        #-Wlogical-op
        #-Wvector-optimization-performance
        )
      

      Of those, the following produce a warning with gcc8 with cause CMake to abort the compilation. Therefore they have to be removed. This pertains all versions. It probably does not trigger with old CMake versions or older gcc versions that do not print those warnings.

      -Wbad-function-cast
      -Wstrict-prototypes
      -Wmissing-prototypes
      

      Warnings:
      cc1plus: warning: command line option '-Wbad-function-cast' is valid for C/ObjC but not for C++
      cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
      cc1plus: warning: command line option '-Wmissing-prototypes' is valid for C/ObjC but not for C++
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                wlad Vladislav Vaintroub
                Reporter:
                thermi Noel Kuntze
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: