Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.3(EOL)
-
None
-
Arch Linux, gcc8
Description
The CMake code of the tokudb build files sets and checks the following cflags:
set_cflags_if_supported(
|
-Wextra
|
-Wbad-function-cast
|
-Wno-missing-noreturn
|
-Wstrict-prototypes
|
-Wmissing-prototypes
|
-Wmissing-declarations
|
-Wpointer-arith
|
#-Wshadow will fail with GCC-8
|
${OPTIONAL_CFLAGS}
|
## other flags to try:
|
#-Wunsafe-loop-optimizations
|
#-Wpointer-arith
|
#-Wc++-compat
|
#-Wc++11-compat
|
#-Wwrite-strings
|
#-Wzero-as-null-pointer-constant
|
#-Wlogical-op
|
#-Wvector-optimization-performance
|
)
|
Of those, the following produce a warning with gcc8 with cause CMake to abort the compilation. Therefore they have to be removed. This pertains all versions. It probably does not trigger with old CMake versions or older gcc versions that do not print those warnings.
-Wbad-function-cast
|
-Wstrict-prototypes
|
-Wmissing-prototypes
|
Warnings:
|
cc1plus: warning: command line option '-Wbad-function-cast' is valid for C/ObjC but not for C++
|
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
|
cc1plus: warning: command line option '-Wmissing-prototypes' is valid for C/ObjC but not for C++
|
Attachments
Issue Links
- duplicates
-
-
- Closed
-
- relates to
-
-
- Closed
-
- links to
Activity
| Field | Original Value | New Value |
|---|---|---|
| Component/s | Storage Engine - TokuDB [ 10134 ] |
| Fix Version/s | 10.3 [ 22126 ] | |
| Affects Version/s | 10.3 [ 22126 ] | |
| Assignee | Sergei Golubchik [ serg ] |
| Fix Version/s | 10.4 [ 22408 ] |
I wrote a rather large patch that seperates the handling of CFLAGS and CXXFLAGS to make sure invalid options are never passed to the corresponding compiler. The patch is in total around 600 lines.
| Link |
This issue relates to |
| Link |
This issue relates to |
| Link |
This issue relates to |
| Status | Open [ 1 ] | Confirmed [ 10101 ] |
| Assignee | Sergei Golubchik [ serg ] | Anel Husakovic [ anel ] |
| Assignee | Anel Husakovic [ anel ] | Vladislav Vaintroub [ wlad ] |
| Status | Confirmed [ 10101 ] | In Review [ 10002 ] |
| Link |
This issue relates to |
| Link |
This issue relates to |
| Remote Link | This issue links to "PR #1318 (Web Link)" [ 29021 ] |
I don't get it. First, I have gcc8 and everything compiles fine. Second, MY_CHECK_AND_SET_COMPILER_FLAG macro checks C and C++ separately and does not enable C++ flags for C or vice versa.
Why one would need to separate options into C and C++ manually (which is error prone and, quite probably, depends on the compiler version) when currently cmake does all that automatically? Or at least is supposed to.
maybe thermi could attach build log to the bug so we get an idea. Also CMakeFiles/CMakeOutput.log and CMakeFiles/CMakeError.log, in tar.gz or zip
| Attachment | CMakeOutput.log [ 48176 ] |
| Attachment | CMakeError.log [ 48177 ] |
I just figured out that the problem is only caused when LANG is not set to C.
CMakeOutput.log and CMakeError.log are attached. CMakeOutput.log
CMakeError.log
SET(fail_patterns) in cmake/check_compiler_flag.cmake muß ein wenig Deutsch üben.
serg, was meinst Du dazu?
maybe
|
set(ENV{LANG} C)
|
in MY_CHECK_C_COMPILER_FLAG,MY_CHECK_CXX_COMPILER_FLAG helps
thermi, kannst Du ausprobieren ob es hilft?
| issue.field.resolutiondate | 2019-06-05 17:44:24.0 | 2019-06-05 17:44:24.149 |
| Fix Version/s | 10.1.41 [ 23406 ] | |
| Fix Version/s | 10.2.25 [ 23408 ] | |
| Fix Version/s | 10.3.16 [ 23410 ] | |
| Fix Version/s | 10.4.6 [ 23412 ] | |
| Fix Version/s | 10.3 [ 22126 ] | |
| Fix Version/s | 10.4 [ 22408 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | In Review [ 10002 ] | Closed [ 6 ] |
| Link |
This issue duplicates |
| Workflow | MariaDB v3 [ 89168 ] | MariaDB v4 [ 154876 ] |
More wrong cflags:
-fimplicit-templates
-std=c++11
-Wstrict-null-sentinel
-Wtautological-constant-out-of-range-compare
-Waddress-of-array-temporary